Skip to content

Fix tests on single-GPU machine #16911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 3, 2023
Merged

Fix tests on single-GPU machine #16911

merged 5 commits into from
Mar 3, 2023

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Mar 1, 2023

What does this PR do?

Fixes testing issues introduced in #16842

cc @carmocca @justusschock @awaelchli @Borda

@carmocca carmocca added fabric lightning.fabric.Fabric tests labels Mar 1, 2023
@carmocca carmocca self-assigned this Mar 1, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 1, 2023

⛈️ Required checks status: Has failure 🔴

Warning
This job will need to be re-run to merge your PR. If you do not have write access to the repository, you can ask Lightning-AI/lai-frameworks to re-run it. If you push a new commit, all of CI will re-trigger.

Groups summary

🔴 pytorch_lightning: Tests workflow
Check ID Status
pl-cpu (macOS-11, lightning, 3.8, 1.11) in_progress
pl-cpu (macOS-11, lightning, 3.9, 1.12) in_progress
pl-cpu (macOS-11, lightning, 3.10, 1.13) in_progress
pl-cpu (macOS-11, lightning, 3.8, 1.11, oldest) in_progress
pl-cpu (macOS-11, lightning, 3.9, 2.0, pre) in_progress
pl-cpu (ubuntu-20.04, lightning, 3.9, 1.11) success
pl-cpu (ubuntu-20.04, lightning, 3.10, 1.12) success
pl-cpu (ubuntu-20.04, lightning, 3.10, 1.13) success
pl-cpu (ubuntu-20.04, lightning, 3.8, 1.11, oldest) success
pl-cpu (ubuntu-20.04, lightning, 3.9, 2.0, pre) success
pl-cpu (windows-2022, lightning, 3.9, 1.11) in_progress
pl-cpu (windows-2022, lightning, 3.10, 1.12) success
pl-cpu (windows-2022, lightning, 3.10, 1.13) success
pl-cpu (windows-2022, lightning, 3.8, 1.11, oldest) in_progress
pl-cpu (windows-2022, lightning, 3.9, 2.0, pre) failure
pl-cpu (macOS-11, pytorch, 3.8, 1.13) success
pl-cpu (ubuntu-20.04, pytorch, 3.8, 1.13) success
pl-cpu (windows-2022, pytorch, 3.8, 1.13) failure

These checks are required after the changes to tests/tests_pytorch/trainer/connectors/test_accelerator_connector.py.

🟢 pytorch_lightning: Azure GPU
Check ID Status
pytorch-lightning (GPUs) success

These checks are required after the changes to tests/tests_pytorch/trainer/connectors/test_accelerator_connector.py.

🔴 pytorch_lightning: Azure HPU
Check ID Status
pytorch-lightning (HPUs) failure

These checks are required after the changes to tests/tests_pytorch/trainer/connectors/test_accelerator_connector.py.

🔴 lightning_fabric: CPU workflow
Check ID Status
fabric-cpu (macOS-11, lightning, 3.8, 1.11) success
fabric-cpu (macOS-11, lightning, 3.9, 1.12) success
fabric-cpu (macOS-11, lightning, 3.10, 1.13) success
fabric-cpu (macOS-11, lightning, 3.8, 1.11, oldest) success
fabric-cpu (ubuntu-20.04, lightning, 3.9, 1.11) success
fabric-cpu (ubuntu-20.04, lightning, 3.10, 1.12) success
fabric-cpu (ubuntu-20.04, lightning, 3.10, 1.13) success
fabric-cpu (ubuntu-20.04, lightning, 3.8, 1.11, oldest) success
fabric-cpu (windows-2022, lightning, 3.9, 1.11) failure
fabric-cpu (windows-2022, lightning, 3.10, 1.12) success
fabric-cpu (windows-2022, lightning, 3.10, 1.13) success
fabric-cpu (windows-2022, lightning, 3.8, 1.11, oldest) failure
fabric-cpu (macOS-11, fabric, 3.8, 1.13) success
fabric-cpu (ubuntu-20.04, fabric, 3.8, 1.13) success
fabric-cpu (windows-2022, fabric, 3.8, 1.13) success

These checks are required after the changes to tests/tests_fabric/plugins/precision/test_amp_integration.py, tests/tests_fabric/test_connector.py.

🟢 lightning_fabric: Azure GPU
Check ID Status
lightning-fabric (GPUs) success

These checks are required after the changes to tests/tests_fabric/plugins/precision/test_amp_integration.py, tests/tests_fabric/test_connector.py.


Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@awaelchli awaelchli added this to the 2.0 milestone Mar 1, 2023
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Mar 1, 2023
@codecov
Copy link

codecov bot commented Mar 1, 2023

Codecov Report

Merging #16911 (2c571ae) into master (70b257c) will decrease coverage by 23%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff            @@
##           master   #16911     +/-   ##
=========================================
- Coverage      82%      59%    -23%     
=========================================
  Files         436      412     -24     
  Lines       31561    31265    -296     
=========================================
- Hits        25799    18517   -7282     
- Misses       5762    12748   +6986     

@carmocca carmocca changed the title Fix Fabric tests on single-GPU machine Fix tests on single-GPU machine Mar 1, 2023
@mergify mergify bot added the ready PRs ready to be merged label Mar 1, 2023
@carmocca carmocca merged commit 888686e into master Mar 3, 2023
@carmocca carmocca deleted the fabric/tests branch March 3, 2023 00:33
Borda pushed a commit that referenced this pull request Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package ready PRs ready to be merged tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants