Skip to content

feat: customize gradio components with lightning colors #17054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

KogaiIrina
Copy link
Contributor

@KogaiIrina KogaiIrina commented Mar 13, 2023

What does this PR do?

This PR is customizing the gradio components with lightning colors.

image
image
image
image

If you want to check out the newly styled-components you can run lightning run app lit_gradio_interface_demo.py in the tests dir.

These changes were discussed with @aniketmaurya here:

  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@github-actions github-actions bot added the app (removed) Generic label for Lightning App package label Mar 13, 2023
@KogaiIrina KogaiIrina marked this pull request as draft March 13, 2023 07:00
@awaelchli awaelchli added community This PR is from the community app:frontend labels Mar 13, 2023
@awaelchli awaelchli added this to the v1.9.x milestone Mar 13, 2023
@KogaiIrina KogaiIrina marked this pull request as ready for review March 14, 2023 07:51
@KogaiIrina KogaiIrina requested review from aniketmaurya and removed request for Borda March 14, 2023 09:54
@aniketmaurya
Copy link
Contributor

aniketmaurya commented Mar 24, 2023

@Borda can you please help with the PR review?

@Borda Borda enabled auto-merge (squash) April 24, 2023 08:09
@Borda Borda merged commit 0fdd76d into Lightning-AI:master Apr 24, 2023
@Borda Borda mentioned this pull request Aug 15, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app (removed) Generic label for Lightning App package community This PR is from the community example ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants