Skip to content

Fix adlfs import error when gcsfs is installed #18227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 7, 2023
Merged

Fix adlfs import error when gcsfs is installed #18227

merged 1 commit into from
Aug 7, 2023

Conversation

bilelomrani1
Copy link
Contributor

What does this PR do?

There was a small copy-paste bug in the code that got revised and merged in #18088: adlfs was imported instead of gcsfs.

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@github-actions github-actions bot added the fabric lightning.fabric.Fabric label Aug 3, 2023
@awaelchli awaelchli modified the milestones: 2.1, 2.0.x Aug 3, 2023
@awaelchli awaelchli added community This PR is from the community bug Something isn't working labels Aug 3, 2023
@awaelchli awaelchli requested a review from Borda August 7, 2023 16:37
@mergify mergify bot added the ready PRs ready to be merged label Aug 7, 2023
@awaelchli awaelchli merged commit e42cb0d into Lightning-AI:master Aug 7, 2023
Borda pushed a commit that referenced this pull request Aug 14, 2023
lexierule pushed a commit that referenced this pull request Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working community This PR is from the community fabric lightning.fabric.Fabric ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants