-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Simplify store #18234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Simplify store #18234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Borda
reviewed
Aug 7, 2023
12 tasks
Borda
reviewed
Aug 7, 2023
justusschock
approved these changes
Aug 7, 2023
Co-authored-by: Justus Schock <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #18234 +/- ##
=========================================
- Coverage 83% 61% -22%
=========================================
Files 431 424 -7
Lines 33320 32916 -404
=========================================
- Hits 27821 20110 -7711
- Misses 5499 12806 +7307 |
Borda
approved these changes
Aug 7, 2023
lantiga
approved these changes
Aug 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added comment about multiple files per checkpoint. This is quite essential to introduce early.
lantiga
reviewed
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
First of several pieces to simplify the store:
In follow-ups will add more docs, verification of user input, and other conveniences.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
cc @carmocca @Borda