Relax app dependencies for `lightning` | breaking imports from `L` #18386

Borda · 2023-08-24T14:02:22Z

What does this PR do?

Alternative to #15653 (which would suffer from missing typing)
so if you install lightning_app, nothing changes
but if you install lightning now you would need to install lightning[app]

Before submitting

Was this discussed/agreed via a GitHub issue? (not for typos and docs)
Did you read the contributor guideline, Pull Request section?
Did you make sure your PR does only one thing, instead of bundling different changes together?
Did you make sure to update the documentation with your changes? (if necessary)
Did you write any new necessary tests? (not for typos and docs)
Did you verify new and existing tests pass locally with your changes?
Did you list all the breaking changes introduced by this pull request?
Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist

Is this pull request ready for review? (if not, please submit in draft mode)
Check that all items from Before submitting are resolved
Make sure the title is self-explanatory and the description concisely explains the PR
Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @Borda @carmocca @justusschock @awaelchli @tchaton

github-actions · 2023-08-24T14:03:14Z

⛈️ Required checks status: Has failure 🔴

Warning
This job will need to be re-run to merge your PR. If you do not have write access to the repository, you can ask Lightning-AI/lai-frameworks to re-run it. If you push a new commit, all of CI will re-trigger.

Groups summary

🔴 pytorch_lightning: Tests workflow

Check ID	Status
pl-cpu (macOS-11, lightning, 3.8, 1.11)	success	✅
pl-cpu (macOS-11, lightning, 3.9, 1.12)	success	✅
pl-cpu (macOS-11, lightning, 3.10, 1.13)	success	✅
pl-cpu (macOS-11, lightning, 3.10, 2.0)	success	✅
pl-cpu (macOS-11, lightning, 3.8, 1.11, oldest)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.8, 1.11)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.9, 1.12)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.10, 1.13)	failure	❌
pl-cpu (ubuntu-20.04, lightning, 3.10, 2.0)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.8, 1.11, oldest)	success	✅
pl-cpu (windows-2022, lightning, 3.8, 1.11)	success	✅
pl-cpu (windows-2022, lightning, 3.9, 1.12)	success	✅
pl-cpu (windows-2022, lightning, 3.10, 1.13)	success	✅
pl-cpu (windows-2022, lightning, 3.10, 2.0)	success	✅
pl-cpu (windows-2022, lightning, 3.8, 1.11, oldest)	success	✅
pl-cpu (macOS-11, pytorch, 3.8, 1.13)	success	✅
pl-cpu (ubuntu-20.04, pytorch, 3.8, 1.13)	success	✅
pl-cpu (windows-2022, pytorch, 3.8, 1.13)	success	✅

These checks are required after the changes to .actions/assistant.py, tests/tests_pytorch/utilities/test_imports.py.

🟢 pytorch_lightning: Azure GPU

Check ID	Status
[pytorch-lightning (GPUs) (testing Lightning	latest)](https://dev.azure.com/Lightning-AI/72ab7ed8-b00f-4b6e-b131-3388f7ffafa7/_build/results?buildId=171486&view=logs&jobId=47e66f3c-897a-5428-da11-bf5c7745762e)	success
[pytorch-lightning (GPUs) (testing PyTorch	latest)](https://dev.azure.com/Lightning-AI/72ab7ed8-b00f-4b6e-b131-3388f7ffafa7/_build/results?buildId=171486&view=logs&jobId=3f274fac-2e11-54ca-487e-194c91f3ae9f)	success

These checks are required after the changes to .actions/assistant.py, src/lightning/__init__.py, src/lightning/__setup__.py, tests/tests_pytorch/utilities/test_imports.py.

🟢 fabric: Docs

Check ID	Status
docs-checks (fabric, doctest)	success	✅
make-html (fabric)	success	✅

These checks are required after the changes to .github/workflows/docs-build.yml.

🟢 pytorch_lightning: Docs

Check ID	Status
docs-checks (pytorch, doctest)	success	✅
make-html (pytorch)	success	✅

These checks are required after the changes to .actions/assistant.py, .github/workflows/docs-build.yml.

🟢 pytorch_lightning: Docker

Check ID	Status
build-cuda (3.9, 1.12, 11.7.1)	success	✅
build-cuda (3.9, 1.13, 11.8.0)	success	✅
build-cuda (3.9, 1.13, 12.0.1)	success	✅
build-cuda (3.10, 2.0, 11.8.0)	success	✅
build-cuda (3.10, 2.0, 12.0.1)	success	✅
build-pl (3.9, 1.12, 11.7.1)	success	✅
build-pl (3.9, 1.13, 11.8.0)	success	✅
build-pl (3.9, 1.13, 12.0.1)	success	✅
build-pl (3.10, 2.0, 11.8.0)	success	✅
build-pl (3.10, 2.0, 12.0.1)	success	✅

These checks are required after the changes to .actions/assistant.py.

🟢 lightning_data: CPU workflow

Check ID	Status
data-cpu (macOS-11, lightning, 3.10, 2.0)	success	✅
data-cpu (ubuntu-20.04, lightning, 3.10, 2.0)	success	✅
data-cpu (windows-2022, lightning, 3.10, 2.0)	success	✅

These checks are required after the changes to .actions/assistant.py, examples/data/image/imagenet.py.

🟢 lightning_fabric: CPU workflow

Check ID	Status
fabric-cpu (macOS-11, lightning, 3.8, 1.11)	success	✅
fabric-cpu (macOS-11, lightning, 3.9, 1.12)	success	✅
fabric-cpu (macOS-11, lightning, 3.10, 1.13)	success	✅
fabric-cpu (macOS-11, lightning, 3.10, 2.0)	success	✅
fabric-cpu (macOS-11, lightning, 3.8, 1.11, oldest)	success	✅
fabric-cpu (ubuntu-20.04, lightning, 3.8, 1.11)	success	✅
fabric-cpu (ubuntu-20.04, lightning, 3.9, 1.12)	success	✅
fabric-cpu (ubuntu-20.04, lightning, 3.10, 1.13)	success	✅
fabric-cpu (ubuntu-20.04, lightning, 3.10, 2.0)	success	✅
fabric-cpu (ubuntu-20.04, lightning, 3.8, 1.11, oldest)	success	✅
fabric-cpu (windows-2022, lightning, 3.8, 1.11)	success	✅
fabric-cpu (windows-2022, lightning, 3.9, 1.12)	success	✅
fabric-cpu (windows-2022, lightning, 3.10, 1.13)	success	✅
fabric-cpu (windows-2022, lightning, 3.10, 2.0)	success	✅
fabric-cpu (windows-2022, lightning, 3.8, 1.11, oldest)	success	✅
fabric-cpu (macOS-11, fabric, 3.8, 1.13)	success	✅
fabric-cpu (ubuntu-20.04, fabric, 3.8, 1.13)	success	✅
fabric-cpu (windows-2022, fabric, 3.8, 1.13)	success	✅

These checks are required after the changes to .actions/assistant.py.

🟢 lightning_fabric: Azure GPU

Check ID	Status
[lightning-fabric (GPUs) (testing Fabric	latest)](https://dev.azure.com/Lightning-AI/72ab7ed8-b00f-4b6e-b131-3388f7ffafa7/_build/results?buildId=171487&view=logs&jobId=3f274fac-2e11-54ca-487e-194c91f3ae9f)	success
[lightning-fabric (GPUs) (testing Lightning	latest)](https://dev.azure.com/Lightning-AI/72ab7ed8-b00f-4b6e-b131-3388f7ffafa7/_build/results?buildId=171487&view=logs&jobId=b2def368-7fa8-5edf-f15e-38e7ac88d76c)	success

These checks are required after the changes to .actions/assistant.py, src/lightning/__init__.py, src/lightning/__setup__.py.

🟢 lightning_app: Tests workflow

Check ID	Status
app-pytest (macOS-11, lightning, 3.8, latest)	success	✅
app-pytest (macOS-11, lightning, 3.8, oldest)	success	✅
app-pytest (macOS-11, app, 3.9, latest)	success	✅
app-pytest (ubuntu-20.04, lightning, 3.8, latest)	success	✅
app-pytest (ubuntu-20.04, lightning, 3.8, oldest)	success	✅
app-pytest (ubuntu-20.04, app, 3.9, latest)	success	✅
app-pytest (windows-2022, lightning, 3.8, latest)	success	✅
app-pytest (windows-2022, lightning, 3.8, oldest)	success	✅
app-pytest (windows-2022, app, 3.8, latest)	success	✅

These checks are required after the changes to .actions/assistant.py, src/lightning/app/__init__.py, src/lightning/app/api/http_methods.py, src/lightning/app/cli/app-template/app.py, src/lightning/app/cli/app-template/placeholdername/components/component_a/component_a.py, src/lightning/app/cli/app-template/placeholdername/components/component_b/component_a.py, src/lightning/app/cli/component-template/app.py, src/lightning/app/cli/component-template/placeholdername/component.py, src/lightning/app/cli/react-ui-template/example_app.py, src/lightning/app/components/multi_node/base.py, src/lightning/app/components/serve/auto_scaler.py, src/lightning/app/components/training.py, src/lightning/app/core/flow.py, src/lightning/app/core/queues.py, src/lightning/app/core/work.py, src/lightning/app/frontend/frontend.py, src/lightning/app/frontend/panel/panel_frontend.py, src/lightning/app/launcher/launcher.py, src/lightning/app/launcher/lightning_backend.py, src/lightning/app/runners/runtime.py, src/lightning/app/source_code/local.py, src/lightning/app/storage/orchestrator.py, src/lightning/app/structures/dict.py, src/lightning/app/structures/list.py, src/lightning/app/testing/helpers.py, src/lightning/app/testing/testing.py, src/lightning/app/utilities/component.py, src/lightning/app/utilities/introspection.py, src/lightning/app/utilities/load_app.py, src/lightning/app/utilities/packaging/build_config.py, src/lightning/app/utilities/proxies.py, src/lightning/app/utilities/types.py, src/lightning_app/__setup__.py, tests/tests_app/cli/launch_data/app_v0/app.py, tests/tests_app/core/scripts/app_with_env.py, requirements/app/app.txt.

🟢 lightning_app: Examples

Check ID	Status
app-examples (macOS-11, lightning, 3.9, latest)	success	✅
app-examples (macOS-11, lightning, 3.9, oldest)	success	✅
app-examples (macOS-11, app, 3.9, latest)	success	✅
app-examples (ubuntu-20.04, lightning, 3.9, latest)	success	✅
app-examples (ubuntu-20.04, lightning, 3.9, oldest)	success	✅
app-examples (ubuntu-20.04, app, 3.9, latest)	success	✅
app-examples (windows-2022, lightning, 3.9, latest)	success	✅
app-examples (windows-2022, lightning, 3.9, oldest)	success	✅
app-examples (windows-2022, app, 3.9, latest)	success	✅

These checks are required after the changes to .actions/assistant.py, src/lightning/app/__init__.py, src/lightning/app/api/http_methods.py, src/lightning/app/cli/app-template/app.py, src/lightning/app/cli/app-template/placeholdername/components/component_a/component_a.py, src/lightning/app/cli/app-template/placeholdername/components/component_b/component_a.py, src/lightning/app/cli/component-template/app.py, src/lightning/app/cli/component-template/placeholdername/component.py, src/lightning/app/cli/react-ui-template/example_app.py, src/lightning/app/components/multi_node/base.py, src/lightning/app/components/serve/auto_scaler.py, src/lightning/app/components/training.py, src/lightning/app/core/flow.py, src/lightning/app/core/queues.py, src/lightning/app/core/work.py, src/lightning/app/frontend/frontend.py, src/lightning/app/frontend/panel/panel_frontend.py, src/lightning/app/launcher/launcher.py, src/lightning/app/launcher/lightning_backend.py, src/lightning/app/runners/runtime.py, src/lightning/app/source_code/local.py, src/lightning/app/storage/orchestrator.py, src/lightning/app/structures/dict.py, src/lightning/app/structures/list.py, src/lightning/app/testing/helpers.py, src/lightning/app/testing/testing.py, src/lightning/app/utilities/component.py, src/lightning/app/utilities/introspection.py, src/lightning/app/utilities/load_app.py, src/lightning/app/utilities/packaging/build_config.py, src/lightning/app/utilities/proxies.py, src/lightning/app/utilities/types.py, src/lightning_app/__setup__.py, examples/app/argparse/app.py, examples/app/boring/app.py, examples/app/boring/app_dynamic.py, examples/app/components/python/app.py, examples/app/components/serve/gradio/app.py, examples/app/dag/app.py, examples/app/display_name/app.py, examples/app/drive/app.py, examples/app/hpo/app_wi_ui.py, examples/app/hpo/app_wo_ui.py, examples/app/hpo/hyperplot.py, examples/app/hpo/objective.py, examples/app/installation_commands/app.py, examples/app/interruptible/app.py, examples/app/layout/app.py, examples/app/mount/app.py, examples/app/multi_node/pl_boring_script.py, examples/app/multi_node/train_any.py, examples/app/multi_node/train_fabric.py, examples/app/multi_node/train_lt.py, examples/app/multi_node/train_lt_script.py, examples/app/multi_node/train_pytorch.py, examples/app/multi_node/train_pytorch_spawn.py, examples/app/payload/app.py, examples/app/pickle_or_not/app.py, examples/app/server/app.py, examples/app/server_with_auto_scaler/app.py, examples/app/v0/app.py, requirements/app/app.txt.

🟢 lightning: Store

Check ID	Status
store-cpu (macOS-11, lightning, 3.10, 2.0)	success	✅
store-cpu (ubuntu-20.04, lightning, 3.10, 2.0)	success	✅
store-cpu (windows-2022, lightning, 3.10, 2.0)	success	✅

These checks are required after the changes to .github/workflows/ci-tests-store.yml, src/lightning/__init__.py, src/lightning/__setup__.py.

🔴 lightning_app: Docs

Check ID	Status
docs-checks (app, doctest)	success	✅
make-html (app)	failure	❌

These checks are required after the changes to .actions/assistant.py, src/lightning/app/__init__.py, src/lightning/app/api/http_methods.py, src/lightning/app/cli/app-template/app.py, src/lightning/app/cli/app-template/placeholdername/components/component_a/component_a.py, src/lightning/app/cli/app-template/placeholdername/components/component_b/component_a.py, src/lightning/app/cli/component-template/app.py, src/lightning/app/cli/component-template/placeholdername/component.py, src/lightning/app/cli/react-ui-template/example_app.py, src/lightning/app/components/multi_node/base.py, src/lightning/app/components/serve/auto_scaler.py, src/lightning/app/components/training.py, src/lightning/app/core/flow.py, src/lightning/app/core/queues.py, src/lightning/app/core/work.py, src/lightning/app/frontend/frontend.py, src/lightning/app/frontend/panel/panel_frontend.py, src/lightning/app/launcher/launcher.py, src/lightning/app/launcher/lightning_backend.py, src/lightning/app/runners/runtime.py, src/lightning/app/source_code/local.py, src/lightning/app/storage/orchestrator.py, src/lightning/app/structures/dict.py, src/lightning/app/structures/list.py, src/lightning/app/testing/helpers.py, src/lightning/app/testing/testing.py, src/lightning/app/utilities/component.py, src/lightning/app/utilities/introspection.py, src/lightning/app/utilities/load_app.py, src/lightning/app/utilities/packaging/build_config.py, src/lightning/app/utilities/proxies.py, src/lightning/app/utilities/types.py, src/lightning_app/__setup__.py, docs/source-app/code_samples/basics/0.py, docs/source-app/code_samples/basics/1.py, docs/source-app/code_samples/convert_pl_to_app/app.py, docs/source-app/code_samples/quickstart/app/app_0.py, docs/source-app/code_samples/quickstart/app/app_1.py, docs/source-app/code_samples/quickstart/app_01.py, docs/source-app/code_samples/quickstart/app_02.py, docs/source-app/code_samples/quickstart/app_03.py, docs/source-app/code_samples/quickstart/app_comp.py, docs/source-app/code_samples/quickstart/hello_world/app.py, docs/source-app/code_samples/quickstart/hello_world/app_ui.py, docs/source-app/conf.py, docs/source-app/core_api/lightning_app/app.py, docs/source-app/examples/file_server/app.py, docs/source-app/examples/github_repo_runner/app.py, docs/source-app/landing_app.py, docs/source-app/levels/basic/hello_components/deploy_model.py, docs/source-app/levels/basic/hello_components/hello_world.py, docs/source-app/levels/basic/hello_components/hello_world_gpu.py, docs/source-app/levels/basic/hello_components/multi_node.py, docs/source-app/levels/basic/hello_components/pl_multinode.py, docs/source-app/levels/basic/hello_components/pt_multinode.py, docs/source-app/levels/basic/hello_components/run_ptl_script.py, docs/source-app/levels/basic/hello_components/streamlit_demo.py, docs/source-app/levels/basic/hello_components/train_ptl.py, docs/source-app/levels/basic/hello_components/train_pytorch.py, docs/source-app/levels/basic/hello_components/xgboost.py, docs/source-app/levels/basic/hello_components/xgboost_gpu.py, docs/source-app/levels/basic/key_features/accelerators.py, docs/source-app/levels/basic/key_features/auto_timeout.py, docs/source-app/levels/basic/key_features/custom_container.py, docs/source-app/levels/basic/key_features/idle_machine.py, docs/source-app/levels/basic/key_features/massive_dataset.py, docs/source-app/levels/basic/key_features/mount_data.py, docs/source-app/levels/basic/key_features/spot.py, docs/source-app/levels/basic/scripts/toy_app_1_component.py, docs/source-app/levels/basic/scripts/toy_app_1_component_pdb.py, docs/source-app/levels/intermediate/debug_app_scripts/debug_app.py, docs/source-app/levels/intermediate/debug_app_scripts/toy_app.py, docs/source-app/levels/intermediate/debug_app_scripts/toy_app_1_component.py, docs/source-app/levels/intermediate/debug_app_scripts/toy_app_1_component_pdb.py, docs/source-app/levels/intermediate/level_2_scripts/hello_app.py, docs/source-app/levels/intermediate/level_2_scripts/hello_app_auto_scale.py, docs/source-app/levels/intermediate/level_2_scripts/hello_app_cron.py, docs/source-app/levels/intermediate/level_2_scripts/hello_app_scheduler.py, docs/source-app/levels/intermediate/level_2_scripts/organized_app_python.py, docs/source-app/levels/intermediate/scripts/comms_1.py, docs/source-app/levels/intermediate/scripts/debug_app.py, docs/source-app/levels/intermediate/scripts/toy_app.py, docs/source-app/levels/intermediate/scripts/toy_payload.py, docs/source-app/levels/intermediate/scripts/two_comms_non_ml.py, docs/source-app/levels/intermediate/scripts/two_work_comms.py, docs/source-app/workflows/add_web_ui/dash/intermediate_plot.py, docs/source-app/workflows/add_web_ui/dash/intermediate_state.py, docs/source-app/workflows/build_command_line_interface/app.py, docs/source-app/workflows/build_command_line_interface/post_example.py, docs/source-app/workflows/build_rest_api/post_example.py, docs/source-app/workflows/build_rest_api/post_example_pydantic.py, docs/source-app/workflows/scripts/parallel/toy_app.py, docs/source-app/workflows/scripts/parallel/toy_parallel.py, docs/source-app/workflows/scripts/parallel/toy_two_parallel.py, docs/source-app/workflows/scripts/parallel/toy_two_parallel_not_started.py, docs/source-app/workflows/share_files_between_components/app.py, .github/workflows/docs-build.yml, requirements/app/app.txt.

🟢 mypy

Check ID	Status
mypy	success	✅

These checks are required after the changes to .actions/assistant.py, requirements/app/app.txt, src/lightning/__init__.py, src/lightning/__setup__.py, src/lightning/app/__init__.py, src/lightning/app/api/http_methods.py, src/lightning/app/cli/app-template/app.py, src/lightning/app/cli/app-template/placeholdername/components/component_a/component_a.py, src/lightning/app/cli/app-template/placeholdername/components/component_b/component_a.py, src/lightning/app/cli/component-template/app.py, src/lightning/app/cli/component-template/placeholdername/component.py, src/lightning/app/cli/react-ui-template/example_app.py, src/lightning/app/components/multi_node/base.py, src/lightning/app/components/serve/auto_scaler.py, src/lightning/app/components/training.py, src/lightning/app/core/flow.py, src/lightning/app/core/queues.py, src/lightning/app/core/work.py, src/lightning/app/frontend/frontend.py, src/lightning/app/frontend/panel/panel_frontend.py, src/lightning/app/launcher/launcher.py, src/lightning/app/launcher/lightning_backend.py, src/lightning/app/runners/runtime.py, src/lightning/app/source_code/local.py, src/lightning/app/storage/orchestrator.py, src/lightning/app/structures/dict.py, src/lightning/app/structures/list.py, src/lightning/app/testing/helpers.py, src/lightning/app/testing/testing.py, src/lightning/app/utilities/component.py, src/lightning/app/utilities/introspection.py, src/lightning/app/utilities/load_app.py, src/lightning/app/utilities/packaging/build_config.py, src/lightning/app/utilities/proxies.py, src/lightning/app/utilities/types.py, src/lightning_app/__setup__.py.

🟢 install

Check ID	Status
install-pkg (ubuntu-22.04, app, 3.8)	success	✅
install-pkg (ubuntu-22.04, app, 3.10)	success	✅
install-pkg (ubuntu-22.04, fabric, 3.8)	success	✅
install-pkg (ubuntu-22.04, fabric, 3.10)	success	✅
install-pkg (ubuntu-22.04, pytorch, 3.8)	success	✅
install-pkg (ubuntu-22.04, pytorch, 3.10)	success	✅
install-pkg (ubuntu-22.04, lightning, 3.8)	success	✅
install-pkg (ubuntu-22.04, lightning, 3.10)	success	✅
install-pkg (ubuntu-22.04, notset, 3.8)	success	✅
install-pkg (ubuntu-22.04, notset, 3.10)	success	✅
install-pkg (macOS-12, app, 3.8)	success	✅
install-pkg (macOS-12, app, 3.10)	success	✅
install-pkg (macOS-12, fabric, 3.8)	success	✅
install-pkg (macOS-12, fabric, 3.10)	success	✅
install-pkg (macOS-12, pytorch, 3.8)	success	✅
install-pkg (macOS-12, pytorch, 3.10)	success	✅
install-pkg (macOS-12, lightning, 3.8)	success	✅
install-pkg (macOS-12, lightning, 3.10)	success	✅
install-pkg (macOS-12, notset, 3.8)	success	✅
install-pkg (macOS-12, notset, 3.10)	success	✅
install-pkg (windows-2022, app, 3.8)	success	✅
install-pkg (windows-2022, app, 3.10)	success	✅
install-pkg (windows-2022, fabric, 3.8)	success	✅
install-pkg (windows-2022, fabric, 3.10)	success	✅
install-pkg (windows-2022, pytorch, 3.8)	success	✅
install-pkg (windows-2022, pytorch, 3.10)	success	✅
install-pkg (windows-2022, lightning, 3.8)	success	✅
install-pkg (windows-2022, lightning, 3.10)	success	✅
install-pkg (windows-2022, notset, 3.8)	success	✅
install-pkg (windows-2022, notset, 3.10)	success	✅

These checks are required after the changes to .actions/assistant.py, .github/actions/pkg-install/action.yml, .github/workflows/ci-pkg-install.yml, src/lightning/__init__.py, src/lightning/__setup__.py, src/lightning/app/__init__.py, src/lightning/app/api/http_methods.py, src/lightning/app/cli/app-template/app.py, src/lightning/app/cli/app-template/placeholdername/components/component_a/component_a.py, src/lightning/app/cli/app-template/placeholdername/components/component_b/component_a.py, src/lightning/app/cli/component-template/app.py, src/lightning/app/cli/component-template/placeholdername/component.py, src/lightning/app/cli/react-ui-template/example_app.py, src/lightning/app/components/multi_node/base.py, src/lightning/app/components/serve/auto_scaler.py, src/lightning/app/components/training.py, src/lightning/app/core/flow.py, src/lightning/app/core/queues.py, src/lightning/app/core/work.py, src/lightning/app/frontend/frontend.py, src/lightning/app/frontend/panel/panel_frontend.py, src/lightning/app/launcher/launcher.py, src/lightning/app/launcher/lightning_backend.py, src/lightning/app/runners/runtime.py, src/lightning/app/source_code/local.py, src/lightning/app/storage/orchestrator.py, src/lightning/app/structures/dict.py, src/lightning/app/structures/list.py, src/lightning/app/testing/helpers.py, src/lightning/app/testing/testing.py, src/lightning/app/utilities/component.py, src/lightning/app/utilities/introspection.py, src/lightning/app/utilities/load_app.py, src/lightning/app/utilities/packaging/build_config.py, src/lightning/app/utilities/proxies.py, src/lightning/app/utilities/types.py, src/lightning_app/__setup__.py, requirements/app/app.txt.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

for more information, see https://pre-commit.ci

…ng/pytorch-lightning into refactor/app-root

for more information, see https://pre-commit.ci

…ng/pytorch-lightning into refactor/app-root

for more information, see https://pre-commit.ci

…ng/pytorch-lightning into refactor/app-root

src/lightning/__init__.py

…ng/pytorch-lightning into refactor/app-root

Borda · 2023-08-25T21:39:55Z

Note that the difference grew from 100 lines to 600 lines because we decided to go with breaking change instead of soft change, ref: #18386 (comment)

make App conditional import

d5d1e4b

Borda added refactor priority: 1 Medium priority task labels Aug 24, 2023

Borda added this to the 2.1 milestone Aug 24, 2023

github-actions bot added the app (removed) Generic label for Lightning App package label Aug 24, 2023

Borda changed the title ~~relax App dependencies for lightning~~ relax App dependencies for lightning [wip] Aug 24, 2023

Borda marked this pull request as ready for review August 24, 2023 14:02

Borda requested review from carmocca, justusschock, lantiga, tchaton and awaelchli as code owners August 24, 2023 14:02

pre-commit-ci bot and others added 3 commits August 24, 2023 14:05

[pre-commit.ci] auto fixes from pre-commit.com hooks

024d8e3

for more information, see https://pre-commit.ci

ci: min req.

390b79f

Merge branch 'refactor/app-root' of https://github.com/PyTorchLightni…

6645270

…ng/pytorch-lightning into refactor/app-root

Borda requested a review from ethanwharris as a code owner August 24, 2023 14:19

github-actions bot added the ci Continuous Integration label Aug 24, 2023

Borda added 3 commits August 24, 2023 16:27

data + store

0ffc87d

typo

dde235a

module_available

26106cf

github-actions bot added the pl Generic label for PyTorch Lightning package label Aug 24, 2023

Borda and others added 8 commits August 24, 2023 22:22

extra

e96897e

[pre-commit.ci] auto fixes from pre-commit.com hooks

507d30b

for more information, see https://pre-commit.ci

typo

a7c7eaa

Merge branch 'refactor/app-root' of https://github.com/PyTorchLightni…

7788b15

…ng/pytorch-lightning into refactor/app-root

[pre-commit.ci] auto fixes from pre-commit.com hooks

12a4c9f

for more information, see https://pre-commit.ci

envs

50ab100

Merge branch 'refactor/app-root' of https://github.com/PyTorchLightni…

75a3c59

…ng/pytorch-lightning into refactor/app-root

doctest

2559bcb

Borda and others added 2 commits August 25, 2023 10:44

Apply suggestions from code review

f3a211f

warnings

c771d95

Borda commented Aug 25, 2023

View reviewed changes

src/lightning/__init__.py Outdated Show resolved Hide resolved

breaking

18d2b4f

Borda added the breaking change Includes a breaking change label Aug 25, 2023

Borda and others added 2 commits August 25, 2023 17:35

...

33408d7

Merge branch 'master' into refactor/app-root

8500cd0

Borda changed the title ~~Relax app dependencies for lightning~~ Relax app dependencies for lightning [wip] Aug 25, 2023

Borda added 5 commits August 25, 2023 21:42

fixing source

8d81c50

fixing examples

454ea08

fixing tests

b0dc1f0

fixing docs

7e17502

Merge branch 'refactor/app-root' of https://github.com/PyTorchLightni…

f896881

…ng/pytorch-lightning into refactor/app-root

Borda requested review from nohalon and williamFalcon as code owners August 25, 2023 19:59

fixing source

78cf7a2

Borda force-pushed the refactor/app-root branch from 5648d1a to 78cf7a2 Compare August 25, 2023 20:34

Borda added 2 commits August 25, 2023 22:56

fix mock

0aed015

fix trainer

249e670

Borda force-pushed the refactor/app-root branch from d6ffe8a to 249e670 Compare August 25, 2023 21:22

Merge branch 'master' into refactor/app-root

b6be6be

Borda changed the title ~~Relax app dependencies for lightning [wip]~~ Relax app dependencies for lightning | breaking imports from L Aug 25, 2023

lexierule merged commit 5f5d99e into master Aug 28, 2023

lexierule deleted the refactor/app-root branch August 28, 2023 15:29

0x404 mentioned this pull request Sep 4, 2023

requirements/app/base.txt missing #18474

Closed

This was referenced Sep 10, 2023

Reduce the import time of pytorch_lightning #12786

Closed

Support partial installation of the lightning package #15505

Closed

Borda mentioned this pull request Oct 4, 2023

update the defaults in requirements.txt #18715

Merged

7 tasks

awaelchli mentioned this pull request Oct 18, 2023

lightning run cli entry point stopped working after dropping app from top level #18815

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Relax app dependencies for `lightning` | breaking imports from `L` #18386

Relax app dependencies for `lightning` | breaking imports from `L` #18386

Uh oh!

Borda commented Aug 24, 2023 •

edited by github-actions bot

Loading

Uh oh!

github-actions bot commented Aug 24, 2023 •

edited

Loading

Uh oh!

Uh oh!

Borda commented Aug 25, 2023

Uh oh!

Uh oh!

Relax app dependencies for lightning | breaking imports from L #18386

Relax app dependencies for lightning | breaking imports from L #18386

Uh oh!

Conversation

Borda commented Aug 24, 2023 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

PR review

Uh oh!

github-actions bot commented Aug 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⛈️ Required checks status: Has failure 🔴

Groups summary

Uh oh!

Uh oh!

Borda commented Aug 25, 2023

Uh oh!

Uh oh!

Relax app dependencies for `lightning` | breaking imports from `L` #18386

Relax app dependencies for `lightning` | breaking imports from `L` #18386

Borda commented Aug 24, 2023 •

edited by github-actions bot

Loading

github-actions bot commented Aug 24, 2023 •

edited

Loading