-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Lazily import dependencies for WandbLogger #18538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
for more information, see https://pre-commit.ci
…into refactor/wandb-import-overhead
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #18538 +/- ##
==========================================
- Coverage 85% 50% -35%
==========================================
Files 427 419 -8
Lines 33383 33261 -122
==========================================
- Hits 28390 16728 -11662
- Misses 4993 16533 +11540 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Honest work!
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Jít would be probably better name then lazy... =)
What does this PR do?
Refactors the wandb logger module to lazily import its dependencies only when the WandbLogger instance is requested.
Same idea as #18528
Part of #12786
📚 Documentation preview 📚: https://pytorch-lightning--18538.org.readthedocs.build/en/18538/
cc @justusschock @awaelchli @morganmcg1 @borisdayma @scottire @parambharat @Borda