-
Notifications
You must be signed in to change notification settings - Fork 3.5k
fix compatibility for pytest 8 #20575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Borda
reviewed
Feb 7, 2025
lantiga
approved these changes
Feb 18, 2025
Borda
approved these changes
Feb 18, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #20575 +/- ##
=========================================
- Coverage 88% 49% -39%
=========================================
Files 267 264 -3
Lines 23380 23324 -56
=========================================
- Hits 20481 11382 -9099
- Misses 2899 11942 +9043 |
Hi @Borda , is there a next-step for me to get this PR merged? Thanks! |
justusschock
approved these changes
Feb 24, 2025
Borda
pushed a commit
that referenced
this pull request
Mar 12, 2025
Co-authored-by: Haifeng Jin <[email protected]> (cherry picked from commit 7bd9279)
lexierule
pushed a commit
that referenced
this pull request
Mar 18, 2025
Co-authored-by: Haifeng Jin <[email protected]> (cherry picked from commit 7bd9279)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The test
test_seed_stays_same_with_multiple_seed_everything_calls
is only compatible withpytest==7
, but notpytest==8
due to its passingNone
topytest.warns()
, which is deprecated.This PR fixes the test by making it compatible with both
pytest
7 & 8.more context:
We (Google) uses a monorepo that enforces the pytest version to be 8 for now.
We want to be able to run the unit tests instead of just importing the code.
So, we would like to make this compatibility fix.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
📚 Documentation preview 📚: https://pytorch-lightning--20575.org.readthedocs.build/en/20575/