-
Notifications
You must be signed in to change notification settings - Fork 3.5k
fix: always call WandbLogger.experiment
first in _call_setup_hook
to ensure tensorboard
logs can sync to wandb
#20610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Borda
merged 5 commits into
Lightning-AI:master
from
ringohoffman:create-wandb-experiment-before-tensorboard
Mar 10, 2025
Merged
fix: always call WandbLogger.experiment
first in _call_setup_hook
to ensure tensorboard
logs can sync to wandb
#20610
Borda
merged 5 commits into
Lightning-AI:master
from
ringohoffman:create-wandb-experiment-before-tensorboard
Mar 10, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ensure tensorboard logs sync to wandb wandb/wandb#1782 (comment)
WandbLogger.experiment
first in _call_setup_hook
to ensure tensorboard logs sync to wandbWandbLogger.experiment
first in _call_setup_hook
to ensure tensorboard
logs sync to wandb
WandbLogger.experiment
first in _call_setup_hook
to ensure tensorboard
logs sync to wandb
WandbLogger.experiment
first in _call_setup_hook
to ensure tensorboard
logs can sync to wandb
the trainer tests don't run with wandb installed, so we can't put it there
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #20610 +/- ##
=========================================
- Coverage 88% 79% -9%
=========================================
Files 267 264 -3
Lines 23366 23313 -53
=========================================
- Hits 20475 18366 -2109
- Misses 2891 4947 +2056 🚀 New features to boost your workflow:
|
cc: @Borda |
Borda
approved these changes
Mar 5, 2025
Thanks for approving! Is this able to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In
lightning.pytorch.trainer.call._call_setup_hook
, sort the logger list when callingexperiment
on all loggers for the first time so thatWandbLogger.experiment
is always called beforeTensorboardLogger.experiment
.This ensures that
wandb.init()
is called before any tensorboardSummaryWriter
are created, thereby guaranteeing that tensorboard logs can be synchronized to Weights and Biases.See:
Also from the Weights and Biases tensorboard integrations page:
Fixes N/A
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
cc: @Borda @awaelchli
📚 Documentation preview 📚: https://pytorch-lightning--20610.org.readthedocs.build/en/20610/