Skip to content

Fix AttributeError with num_processes>1 but no ddp_cpu #4435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix AttributeError with num_processes>1 but no ddp_cpu #4435

wants to merge 1 commit into from

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Oct 29, 2020

What does this PR do?

See the following issue:
Fixes #4356

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • [n/a] Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • [n/a] If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

@carmocca
Copy link
Contributor Author

Closing because of #4356 (comment)

@carmocca carmocca closed this Oct 30, 2020
@carmocca carmocca deleted the bug/4356-num_processes branch November 14, 2021 21:30
@carmocca carmocca self-assigned this Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ddp_cpu breaks while lookinf for .module: ModuleAttributeError: 'BoringModel' object has no attribute 'module'
2 participants