-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Ensure accelerator is valid if running interactively #5970
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
ca6dcb7
added ipython env check
ifsheldon 5ee0322
Merge branch 'master' into ipython_env_check
tchaton df6348d
extracted a method and added a compatibility list
ifsheldon c2d3a12
Merge branch 'master' into ipython_env_check
ifsheldon 5ad468e
fixed fstring
ifsheldon 46dcd8d
inverted if, added early return
ifsheldon e37bbd6
Merge branch 'ipython_env_check' of https://github.com/ifsheldon/pyto…
ifsheldon 6739c36
changed to only checking ipython env
ifsheldon 165dffc
Merge branch 'master' into ipython_env_check
awaelchli da99886
move import to top
ifsheldon 799059c
Merge branch 'ipython_env_check' of https://github.com/ifsheldon/pyto…
ifsheldon a6eaec2
fix formatting, docstring and line length
awaelchli 86f2404
Merge branch 'master' into ipython_env_check
awaelchli c0ff8ce
fix isort
awaelchli 70b7dbf
add test
awaelchli 53dc217
moved compatible list to enum method
ifsheldon e2098c6
merged remote changes
ifsheldon 0676368
fixed a minor print issue
ifsheldon 386e3a9
changed to use utilities.imports
ifsheldon 4384880
added a method to check ipython compatibility
ifsheldon 73b18b1
fixed a minor issue when _distrib_type is None
ifsheldon d2dedab
Fix test
carmocca 4619606
Merge branch 'master' into ipython_env_check
carmocca 990c03e
IPython -> interactive
carmocca 0cbb515
Update tests/accelerators/test_accelerator_connector.py
carmocca File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.