Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Training Type Plugins Registry #6982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Training Type Plugins Registry #6982
Changes from 4 commits
f0aed43
38004f0
25ca516
62a3c9f
a05a0f9
4e9cec8
e85de51
40842af
7ce6f86
8fb0a16
33e5329
73718d8
b691237
870bee5
388e487
adea1b4
410fc61
7af1b65
80bc1c5
6ad2c62
a201087
ef080a8
57c609f
844d2a9
89b1e39
47a6d70
a6001b9
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we maybe make this a general registry and reuse this with flash? We also have a registry in flash and duplicating this does not make sense...
I think you only have to change the naming of the fields...
cc @tchaton
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did think of a generic
LightningRegistry
that could be used for different types. But for now, there has only been a need forTrainingTypePlugins
, we could change it down the road as well, as_TrainingTypePluginsRegistry
is internal.