Typing for Lightning Package

[justusschock]

What does this PR do?

This should enable mypy compatible typing throughout the lightning package. At some point, I had to ignore the type checks from mypy due to known issues or no good workarounds.

Resolves #5023

Completed Packages

• lightning.accelerators
• lightning.callbacks
• lightning.core
• lightning.distributed
• lightning.loggers
• lightning.metrics
• lightning.overrides
• lightning.plugins
• lightning.profiler
• lightning.trainer
• lightning.tuner
• lightning.utilities

Edit: The remaining parts will come in separate PRs to prevent this PR from becoming even larger

Open for discussion: Should we also type the tests? I don't think we have to!

Before submitting

• Was this discussed/approved via a GitHub issue? (not for typos and docs)
• Did you read the contributor guideline, Pull Request section?
• Did you make sure your PR does only one thing, instead of bundling different changes together?
• Did you make sure to update the documentation with your changes? (if necessary)
• Did you write any new necessary tests? (not for typos and docs)
• Did you verify new and existing tests pass locally with your changes?
• Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

• Is this pull request ready for review? (if not, please submit in draft mode)
• Check that all items from Before submitting are resolved
• Make sure the title is self-explanatory and the description concisely explains the PR
• Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

[pep8speaks]

Hello @justusschock! Thanks for updating this PR.

• In the file pytorch_lightning/core/lightning.py:

Line 334:17: E731 do not assign a lambda expression, use a def

• In the file pytorch_lightning/core/memory.py:

Line 259:121: E501 line too long (152 > 120 characters)

• In the file pytorch_lightning/core/optimizer.py:

Line 91:38: E701 multiple statements on one line (colon)

Comment last updated at 2021-04-15 10:49:31 UTC

[Borda]

@justusschock seems you are shooting the types very fast a file per minute, are you using some automated tool for it?

[justusschock]

@Borda no, that's just me :D But actually that wasn't that fast. I started 2 days ago, just didn't push it all

[Borda]

cool, it seems to be very large, could have each sub-package as separate PR, it will be easier to check/merge and lower the change of collision in meantime...

[carmocca]

@justusschock I had #7022 already for accelerator and plugins

[Borda]

@justusschock @awaelchli @carmocca pls sync on #5023 what you are working on :]

[justusschock]

@carmocca Accelerators was easy, basically a noop :) But good to know that i don't need to do plugins :)

[Borda]

@justusschock does this has a successor PR or how this was closed? 🐰