Skip to content

Update CODEOWNERS #7302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 3, 2021
Merged

Conversation

ananthsub
Copy link
Contributor

What does this PR do?

Spread the load better for the API

Fixes #<issue_number>

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Apr 30, 2021

Codecov Report

Merging #7302 (f7c09c0) into master (490cc57) will decrease coverage by 48%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           master   #7302     +/-   ##
========================================
- Coverage      91%     44%    -48%     
========================================
  Files         200     200             
  Lines       12857   12872     +15     
========================================
- Hits        11747    5611   -6136     
- Misses       1110    7261   +6151     

@williamFalcon williamFalcon merged commit 393b252 into Lightning-AI:master May 3, 2021
kaushikb11 pushed a commit to kaushikb11/pytorch-lightning that referenced this pull request May 4, 2021
* Update CODEOWNERS

* @carmocca

* @Borda

* Update CODEOWNERS

Co-authored-by: Jirka Borovec <[email protected]>
Co-authored-by: William Falcon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants