Skip to content

Remove model.trainer call inside of dataloading mixin #7317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 3, 2021

Conversation

ananthsub
Copy link
Contributor

@ananthsub ananthsub commented May 2, 2021

What does this PR do?

Part of better state management: this is a mixin on the trainer. there's no reason for us to use the model's trainer attribute to call this hook. it's a code smell we will redesign as part of #7315

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@ananthsub ananthsub marked this pull request as ready for review May 2, 2021 21:17
@codecov
Copy link

codecov bot commented May 2, 2021

Codecov Report

Merging #7317 (2115bd3) into master (393b252) will decrease coverage by 4%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #7317    +/-   ##
=======================================
- Coverage      91%     87%    -4%     
=======================================
  Files         200     200            
  Lines       12875   12875            
=======================================
- Hits        11765   11220   -545     
- Misses       1110    1655   +545     

@awaelchli awaelchli added this to the v1.3 milestone May 2, 2021
@ananthsub ananthsub added the ready PRs ready to be merged label May 2, 2021
@ananthsub ananthsub merged commit b7a4448 into Lightning-AI:master May 3, 2021
kaushikb11 pushed a commit to kaushikb11/pytorch-lightning that referenced this pull request May 4, 2021
)

* Update data_loading.py

* Update data_loading.py

Co-authored-by: Adrian Wälchli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants