Add DefaultDict typehint for optimizer state in accelerator #7318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ananthsub
requested review from
awaelchli,
justusschock,
kaushikb11,
SeanNaren,
tchaton and
williamFalcon
as code owners
Codecov Report
@@ Coverage Diff @@
## master #7318 +/- ##
======================================
Coverage 87% 87%
======================================
Files 200 200
Lines 12865 12865
======================================
Hits 11210 11210
Misses 1655 1655 |
11 tasks
ananthsub
commented
May 2, 2021
| @@ -114,7 +114,7 @@ def pre_dispatch(self, trainer: 'pl.Trainer') -> None: | |||
| def _move_optimizer_state(self) -> None: | |||
| """ Moves the state of the optimizers to the GPU if needed. """ | |||
| for opt in self.optimizers: | |||
| state = defaultdict(dict) | |||
| state: DefaultDict = defaultdict(dict) | |||
There was a problem hiding this comment.
@awaelchli @Borda @carmocca do you know why this could be merged in #7277 even though the mypy check was failing?
There was a problem hiding this comment.
because mypy check is not enforced and auto merge just merged it.
There was a problem hiding this comment.
Should it be enforced?
There was a problem hiding this comment.
I think it should now that it's green.
cc: @Borda
awaelchli
approved these changes
May 3, 2021
carmocca
approved these changes
May 3, 2021
kaushikb11
pushed a commit
to kaushikb11/pytorch-lightning
that referenced
this pull request
May 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Follow up to #7277
Seeing mypy failures in #7306 because of this missing annotation
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃