Skip to content

Add support for (accelerator='cpu'|'gpu'|'tpu'|'ipu'|'auto') #7808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 53 commits into from
Jul 9, 2021

Conversation

kaushikb11
Copy link
Contributor

@kaushikb11 kaushikb11 commented Jun 2, 2021

What does this PR do?

Breaking down #6090 into three parts:

  • Add support for (accelerator='cpu'|'gpu'|'tpu'|'auto')
  • Add devices flag which would be generic for all accelerators
  • Add training_type flag mapped to Training Plugins.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Jun 2, 2021

Codecov Report

Merging #7808 (a2847ec) into master (3102922) will decrease coverage by 5%.
The diff coverage is 81%.

@@           Coverage Diff           @@
##           master   #7808    +/-   ##
=======================================
- Coverage      93%     88%    -5%     
=======================================
  Files         215     215            
  Lines       13988   14034    +46     
=======================================
- Hits        12965   12342   -623     
- Misses       1023    1692   +669     

@pep8speaks
Copy link

pep8speaks commented Jun 10, 2021

Hello @kaushikb11! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-07-09 14:59:07 UTC

@kaushikb11 kaushikb11 marked this pull request as ready for review June 10, 2021 19:34
@kaushikb11 kaushikb11 self-assigned this Jun 10, 2021
@kaushikb11 kaushikb11 added this to the v1.4 milestone Jun 10, 2021
@kaushikb11 kaushikb11 added the design Includes a design discussion label Jun 10, 2021
@mergify mergify bot added the has conflicts label Jul 7, 2021
@mergify mergify bot removed the has conflicts label Jul 8, 2021
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

accept to unblock

@mergify mergify bot added the has conflicts label Jul 9, 2021
SeanNaren added 2 commits July 9, 2021 15:45
@mergify mergify bot removed the has conflicts label Jul 9, 2021
@SeanNaren SeanNaren added the ready PRs ready to be merged label Jul 9, 2021
Copy link
Member

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, small comments 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Includes a design discussion ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants