Fix mypy in utilities.device_dtype_mixin #8127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stancld
requested review from
Borda,
carmocca,
SeanNaren and
tchaton
as code owners
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## master #8127 +/- ##
=======================================
- Coverage 93% 88% -5%
=======================================
Files 214 214
Lines 13914 13914
=======================================
- Hits 12897 12227 -670
- Misses 1017 1687 +670 |
Borda
approved these changes
Jun 25, 2021
stancld
requested review from
awaelchli,
justusschock,
kaushikb11 and
williamFalcon
as code owners
awaelchli
reviewed
Jun 25, 2021
justusschock
approved these changes
Jul 6, 2021
carmocca
reviewed
Jul 6, 2021
awaelchli
approved these changes
Jul 8, 2021
ananthsub
reviewed
Jul 9, 2021
| super().__init__() | ||
| self._dtype = torch.get_default_dtype() | ||
| self._dtype: Union[str, torch.dtype] = torch.get_default_dtype() | ||
| self._device = torch.device('cpu') |
There was a problem hiding this comment.
deoes device also need the torch.device type?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Part of #7037. This PR disentangles large #7218. It fixes mypy typing in utilities.device_dtype_mixin.py.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃