-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Fix module dict in base finetuning #8170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8170 +/- ##
=======================================
- Coverage 93% 88% -5%
=======================================
Files 211 211
Lines 13440 13442 +2
=======================================
- Hits 12450 11832 -618
- Misses 990 1610 +620 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Would suggest adding ModuleDict
to the type hint for modules
.
* Fix module dict in base finetuning * Update CHANGELOG.md
* Fix module dict in base finetuning * Update CHANGELOG.md
* Fix module dict in base finetuning * Update CHANGELOG.md
* Fix module dict in base finetuning * Update CHANGELOG.md
* Fix module dict in base finetuning * Update CHANGELOG.md
What does this PR do?
Fixes #8169
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃