-
Notifications
You must be signed in to change notification settings - Fork 3.5k
convert warning cache usage to rank_zero_only in WandbLogger #8764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
11 tasks
Codecov Report
@@ Coverage Diff @@
## master #8764 +/- ##
=======================================
- Coverage 93% 89% -4%
=======================================
Files 176 176
Lines 14411 14408 -3
=======================================
- Hits 13352 12769 -583
- Misses 1059 1639 +580 |
n00b question: why do we have both warning cache and rank_zero_warn? Should we use one consistently throughout the codebase? @edward-io |
carmocca
approved these changes
Aug 13, 2021
justusschock
approved these changes
Aug 16, 2021
Borda
approved these changes
Aug 18, 2021
SkafteNicki
approved these changes
Aug 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Discussed in #8714, warning cache can be converted to regular warn call.
Goes after #8714 and #8763
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
I made sure I had fun coding 🙃