Skip to content

convert warning cache usage to rank_zero_only in WandbLogger #8764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Aug 20, 2021

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Aug 6, 2021

What does this PR do?

Discussed in #8714, warning cache can be converted to regular warn call.
Goes after #8714 and #8763

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

@awaelchli awaelchli added logger Related to the Loggers feature Is an improvement or enhancement labels Aug 6, 2021
@awaelchli awaelchli added this to the v1.5 milestone Aug 6, 2021
Base automatically changed from feature/wandb-multi-run to master August 10, 2021 08:14
@awaelchli awaelchli added refactor priority: 2 Low priority task and removed feature Is an improvement or enhancement labels Aug 12, 2021
@awaelchli awaelchli marked this pull request as ready for review August 12, 2021 10:39
@codecov
Copy link

codecov bot commented Aug 12, 2021

Codecov Report

Merging #8764 (9aed18b) into master (413f7b2) will decrease coverage by 4%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #8764    +/-   ##
=======================================
- Coverage      93%     89%    -4%     
=======================================
  Files         176     176            
  Lines       14411   14408     -3     
=======================================
- Hits        13352   12769   -583     
- Misses       1059    1639   +580     

@ananthsub
Copy link
Contributor

n00b question: why do we have both warning cache and rank_zero_warn? Should we use one consistently throughout the codebase? @edward-io

@mergify mergify bot added the ready PRs ready to be merged label Aug 16, 2021
@awaelchli awaelchli enabled auto-merge (squash) August 18, 2021 09:44
@awaelchli awaelchli merged commit ad3f183 into master Aug 20, 2021
@awaelchli awaelchli deleted the feature/wandb-warn-cache branch August 20, 2021 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
logger Related to the Loggers priority: 2 Low priority task ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants