Skip to content

[WIP] Fix mypy typing for utilities.auto_restart #8783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

stancld
Copy link
Contributor

@stancld stancld commented Aug 6, 2021

What does this PR do?

Part of #7037. This PR disentangles large #7218. It fixes mypy typing in utilities.auto_restart.py

There's one last tough mypy issue:

torch_lightning/utilities/auto_restart.py:86: error: Argument 1 to "len" has incompatible type "Union[Sampler[Any], Generator[Any, Any, Any], Iterator[Any]]"; expected "Sized"  [arg-type]

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Aug 6, 2021

Codecov Report

Merging #8783 (60f12e3) into master (f1cc6e3) will decrease coverage by 4%.
The diff coverage is 90%.

@@           Coverage Diff           @@
##           master   #8783    +/-   ##
=======================================
- Coverage      93%     88%    -4%     
=======================================
  Files         169     169            
  Lines       14068   14075     +7     
=======================================
- Hits        13038   12452   -586     
- Misses       1030    1623   +593     

@stancld stancld marked this pull request as ready for review August 6, 2021 21:15
@Borda Borda marked this pull request as draft August 7, 2021 07:07
if self._cached_state_dict is None or self.worker_id not in self._cached_state_dict:
return
self._current_iteration = self._cached_state_dict[self.worker_id]["current_iteration"]
# delete cached state, prevent reloading every time iter() is called
self._cached_state_dict = None
return
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pretty sure this is not necessary :/

Copy link
Contributor

@awaelchli awaelchli Aug 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you think we should we put warn_no_return = False for mypy? @stancld @carmocca

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember I read a PEP recommendation suggesting if there's any return statement within a function, it should be obeyed for the whole function definition. But yes, my suggestion might be redundant here.

@stale
Copy link

stale bot commented Aug 24, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If you need further help see our docs: https://pytorch-lightning.readthedocs.io/en/latest/generated/CONTRIBUTING.html#pull-request or ask the assistance of a core contributor here or on Slack. Thank you for your contributions.

@stale stale bot added the won't fix This will not be worked on label Aug 24, 2021
@stale
Copy link

stale bot commented Aug 29, 2021

This pull request is going to be closed. Please feel free to reopen it create a new from the actual master.

@stale stale bot closed this Aug 29, 2021
@stancld stancld deleted the mypy_utilities_auto-restart branch September 11, 2021 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
won't fix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants