-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[WIP] Fix mypy typing for utilities.auto_restart
#8783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8783 +/- ##
=======================================
- Coverage 93% 88% -4%
=======================================
Files 169 169
Lines 14068 14075 +7
=======================================
- Hits 13038 12452 -586
- Misses 1030 1623 +593 |
for more information, see https://pre-commit.ci
if self._cached_state_dict is None or self.worker_id not in self._cached_state_dict: | ||
return | ||
self._current_iteration = self._cached_state_dict[self.worker_id]["current_iteration"] | ||
# delete cached state, prevent reloading every time iter() is called | ||
self._cached_state_dict = None | ||
return |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pretty sure this is not necessary :/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I remember I read a PEP recommendation suggesting if there's any return
statement within a function, it should be obeyed for the whole function definition. But yes, my suggestion might be redundant here.
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If you need further help see our docs: https://pytorch-lightning.readthedocs.io/en/latest/generated/CONTRIBUTING.html#pull-request or ask the assistance of a core contributor here or on Slack. Thank you for your contributions. |
This pull request is going to be closed. Please feel free to reopen it create a new from the actual master. |
What does this PR do?
Part of #7037. This PR disentangles large #7218. It fixes mypy typing in
utilities.auto_restart.py
There's one last tough mypy issue:
Does your PR introduce any breaking changes? If yes, please list them.
None
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃