-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Deprecate log_gpu_memory
off the Trainer constructor
#9124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate log_gpu_memory
off the Trainer constructor
#9124
Conversation
log_gpu_memory
off Trainer
log_gpu_memory
off Trainerlog_gpu_memory
off the Trainer constructor
Codecov Report
@@ Coverage Diff @@
## master #9124 +/- ##
=======================================
- Coverage 92% 88% -4%
=======================================
Files 175 175
Lines 14665 14667 +2
=======================================
- Hits 13499 12890 -609
- Misses 1166 1777 +611 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ananthsub, let's make sure that all issues being worked on are tracked within the sprint.
|
||
|
||
class LoggerConnector: | ||
def __init__(self, trainer: "pl.Trainer", log_gpu_memory: Optional[str] = None) -> None: | ||
self.trainer = trainer | ||
if log_gpu_memory is not None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you plan adding log_gpu_memory
to the callback in another PR ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If yes, it should be done the other way around.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes #9032
I don't think that's correct, given the comments in the "Pitch" and "Additional context" sections of that issue still need to be resolved before the removal of log_gpu_memory
.
But we can do those in separate PRs
Closing this in favor of the stack @daniellepintz is working on |
What does this PR do?
Fixes #9032
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃