Skip to content

Add on_exception hook to documentation #9365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 11, 2021

Conversation

daniellepintz
Copy link
Contributor

@daniellepintz daniellepintz commented Sep 7, 2021

The on_exception hook was recently added in #9183 but I forgot to add it to the documentation.
In this PR I also make some very minor fixes.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Sep 7, 2021

Codecov Report

Merging #9365 (2dcadd7) into master (b294c57) will decrease coverage by 4%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #9365    +/-   ##
=======================================
- Coverage      93%     89%    -4%     
=======================================
  Files         180     180            
  Lines       15062   15062            
=======================================
- Hits        13983   13370   -613     
- Misses       1079    1692   +613     

@ananthsub ananthsub added the docs Documentation related label Sep 7, 2021
@mergify mergify bot added the ready PRs ready to be merged label Sep 8, 2021
@awaelchli awaelchli added this to the v1.5 milestone Sep 8, 2021
@daniellepintz
Copy link
Contributor Author

Can I get one more review here please?

@rohitgr7 rohitgr7 enabled auto-merge (squash) September 11, 2021 21:14
@rohitgr7 rohitgr7 merged commit 83bff01 into Lightning-AI:master Sep 11, 2021
@daniellepintz daniellepintz deleted the doc_fix branch September 11, 2021 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
callback docs Documentation related ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants