Skip to content

add neptune staff as code owners for neptune.py #9438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 10, 2021

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Sep 10, 2021

What does this PR do?

As the title suggests, we welcome the neptune team to help us maintain the neptune logger integration.

Follow up to #6867

@kamil-kaczmarek

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

@awaelchli awaelchli added admin Requires admin privileges to merge productivity 3rd party Related to a 3rd-party labels Sep 10, 2021
@awaelchli awaelchli added this to the v1.5 milestone Sep 10, 2021
@awaelchli awaelchli changed the title add neptune staff to code-owners for neptune.py add neptune staff as code owners for neptune.py Sep 10, 2021
@kamil-kaczmarek
Copy link
Contributor

hi @awaelchli ,

We happily take that role, as previously proposed in the #6867

@shnela @HubertJaworski @pkasprzyk @pitercl @Raalsky @aniezurawski @kamil-kaczmarek

@awaelchli awaelchli marked this pull request as ready for review September 10, 2021 17:00
@lexierule lexierule merged commit 7ca038b into master Sep 10, 2021
@lexierule lexierule deleted the feature/neptune-code-owners branch September 10, 2021 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3rd party Related to a 3rd-party admin Requires admin privileges to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants