-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Improve collision check on hparams between LightningModule and DataModule #9496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ananthsub
merged 8 commits into
Lightning-AI:master
from
ananthsub:fix/hyperparameter-logging
Sep 17, 2021
Merged
Improve collision check on hparams between LightningModule and DataModule #9496
ananthsub
merged 8 commits into
Lightning-AI:master
from
ananthsub:fix/hyperparameter-logging
Sep 17, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #9496 +/- ##
=======================================
- Coverage 93% 89% -4%
=======================================
Files 180 181 +1
Lines 15116 15178 +62
=======================================
- Hits 14043 13486 -557
- Misses 1073 1692 +619 |
ananthsub
commented
Sep 14, 2021
kaushikb11
approved these changes
Sep 14, 2021
f78363c
to
4ce3b56
Compare
tchaton
approved these changes
Sep 14, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
SeanNaren
approved these changes
Sep 14, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ananthsub!
awaelchli
reviewed
Sep 14, 2021
carmocca
reviewed
Sep 14, 2021
carmocca
reviewed
Sep 14, 2021
4ce3b56
to
798dd99
Compare
awaelchli
approved these changes
Sep 17, 2021
36cf5e6
to
9520979
Compare
carmocca
approved these changes
Sep 17, 2021
SeanNaren
pushed a commit
that referenced
this pull request
Sep 22, 2021
…dule (#9496) * fix hyperparameter logging between LightningModule and DataModule
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #9492
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃