Skip to content

Improve collision check on hparams between LightningModule and DataModule #9496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Sep 17, 2021

Conversation

ananthsub
Copy link
Contributor

@ananthsub ananthsub commented Sep 13, 2021

What does this PR do?

Fixes #9492

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Sep 13, 2021

Codecov Report

Merging #9496 (6140181) into master (45200fc) will decrease coverage by 4%.
The diff coverage is 91%.

@@           Coverage Diff           @@
##           master   #9496    +/-   ##
=======================================
- Coverage      93%     89%    -4%     
=======================================
  Files         180     181     +1     
  Lines       15116   15178    +62     
=======================================
- Hits        14043   13486   -557     
- Misses       1073    1692   +619     

@ananthsub ananthsub marked this pull request as ready for review September 13, 2021 22:07
@ananthsub ananthsub added the feature Is an improvement or enhancement label Sep 13, 2021
@ananthsub ananthsub added this to the v1.5 milestone Sep 13, 2021
@ananthsub ananthsub force-pushed the fix/hyperparameter-logging branch from f78363c to 4ce3b56 Compare September 14, 2021 07:25
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@mergify mergify bot added the ready PRs ready to be merged label Sep 14, 2021
Copy link
Contributor

@SeanNaren SeanNaren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ananthsub!

@ananthsub ananthsub force-pushed the fix/hyperparameter-logging branch from 4ce3b56 to 798dd99 Compare September 17, 2021 01:52
@mergify mergify bot removed the has conflicts label Sep 17, 2021
@ananthsub ananthsub force-pushed the fix/hyperparameter-logging branch from 36cf5e6 to 9520979 Compare September 17, 2021 16:19
@ananthsub ananthsub enabled auto-merge (squash) September 17, 2021 17:49
@ananthsub ananthsub merged commit 856ed10 into Lightning-AI:master Sep 17, 2021
@ananthsub ananthsub deleted the fix/hyperparameter-logging branch September 17, 2021 18:22
SeanNaren pushed a commit that referenced this pull request Sep 22, 2021
…dule (#9496)

* fix hyperparameter logging between LightningModule and DataModule
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Is an improvement or enhancement ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve collision check on hparams between LightningModule and DataModule
6 participants