Skip to content

Small improvements to rich progress bar #9579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 22, 2021
Merged

Small improvements to rich progress bar #9579

merged 3 commits into from
Sep 22, 2021

Conversation

SeanNaren
Copy link
Contributor

@SeanNaren SeanNaren commented Sep 17, 2021

What does this PR do?

Related #9547

Use exposed functions from Rich instead of the context manager. Also fixes a few signatures!

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@SeanNaren SeanNaren self-assigned this Sep 17, 2021
@SeanNaren SeanNaren added the feature Is an improvement or enhancement label Sep 17, 2021
@SeanNaren SeanNaren added this to the v1.5 milestone Sep 17, 2021
@codecov
Copy link

codecov bot commented Sep 17, 2021

Codecov Report

Merging #9579 (bc70bc0) into master (8f1c855) will decrease coverage by 4%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #9579    +/-   ##
=======================================
- Coverage      93%     89%    -4%     
=======================================
  Files         179     179            
  Lines       15317   15317            
=======================================
- Hits        14208   13590   -618     
- Misses       1109    1727   +618     

@mergify mergify bot added the ready PRs ready to be merged label Sep 17, 2021
@SeanNaren SeanNaren enabled auto-merge (squash) September 17, 2021 12:52
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! But I am bit concerned about the double refresh parameters. Not sure how this would play.

@SeanNaren
Copy link
Contributor Author

Thanks for checking this out! Just holding off on this PR till @kaushikb11 has a chance to work through the double refresh. I think the point of the refresh was for performance/logging (I assume) so just need to make sure this aligns.

@SeanNaren
Copy link
Contributor Author

Logic has been simplified, exposing just the rich progress bar refresh rate. I've verified that the progress bar works out of the box on google colab/jupyter notebook so the additional progress bar logic for TQDM is not required

@SeanNaren SeanNaren disabled auto-merge September 22, 2021 14:25
@SeanNaren SeanNaren enabled auto-merge (squash) September 22, 2021 14:27
@SeanNaren SeanNaren merged commit fd2e778 into master Sep 22, 2021
@SeanNaren SeanNaren deleted the feat/cleanup_rich branch September 22, 2021 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Is an improvement or enhancement ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants