-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Small improvements to rich progress bar #9579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9579 +/- ##
=======================================
- Coverage 93% 89% -4%
=======================================
Files 179 179
Lines 15317 15317
=======================================
- Hits 14208 13590 -618
- Misses 1109 1727 +618 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ! But I am bit concerned about the double refresh parameters. Not sure how this would play.
Thanks for checking this out! Just holding off on this PR till @kaushikb11 has a chance to work through the double refresh. I think the point of the refresh was for performance/logging (I assume) so just need to make sure this aligns. |
e84531e
to
46dad64
Compare
Logic has been simplified, exposing just the rich progress bar refresh rate. I've verified that the progress bar works out of the box on google colab/jupyter notebook so the additional progress bar logic for TQDM is not required |
What does this PR do?
Related #9547
Use exposed functions from Rich instead of the context manager. Also fixes a few signatures!
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃