[wip] Support serialized checkpoint loading #9585
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
ananthsub
reviewed
Sep 17, 2021
pytorch_lightning/plugins/training_type/training_type_plugin.py
Outdated
Show resolved
Hide resolved
Comment on lines
+957
to
+958
| if self._ckpt_path: | ||
| self._load_checkpoint_weights() |
There was a problem hiding this comment.
note to reviewer: this must be moved after the setup_environment is called to ensure that torch distributed is initialized. it also matches the symmetry for loading checkpoints after pre-dispatch, and makes it easier for us to reason about merging these checkpoint loading paths altogether.
ananthsub
reviewed
Sep 17, 2021
ananthsub
reviewed
Sep 17, 2021
for more information, see https://pre-commit.ci
* Document exceptions in ipu.py * Document exceptions in tpu.py * Document exceptions in gpu.py
…tly into `trainer.py` (Lightning-AI#9495) Co-authored-by: Adrian Wälchli <[email protected]> Co-authored-by: thomas chaton <[email protected]>
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…iferdai/pytorch-lightning into serialized-load-checkpoint
12 tasks
|
messed up git, moving to #9605 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #9406
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃