Skip to content

[wip] Support serialized checkpoint loading #9585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

jjenniferdai
Copy link
Contributor

What does this PR do?

Fixes #9406

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

Comment on lines +957 to +958
if self._ckpt_path:
self._load_checkpoint_weights()
Copy link
Contributor

@ananthsub ananthsub Sep 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note to reviewer: this must be moved after the setup_environment is called to ensure that torch distributed is initialized. it also matches the symmetry for loading checkpoints after pre-dispatch, and makes it easier for us to reason about merging these checkpoint loading paths altogether.

@ananthsub ananthsub added the checkpointing Related to checkpointing label Sep 17, 2021
@jjenniferdai
Copy link
Contributor Author

messed up git, moving to #9605

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
checkpointing Related to checkpointing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support serialized checkpoint loading
5 participants