Skip to content

Deprecate LightningDistributed and keep logic in ddp/ddpSpawn directly #9691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Sep 25, 2021

Conversation

four4fish
Copy link
Contributor

@four4fish four4fish commented Sep 24, 2021

What does this PR do?

LightningDistributed() class only used by ddp and ddpSpawn, and only have one broadcast function for torch collectives. It's unnecessary to have.
Also, we have to set rank and device in set up steps. If subclass extend DDP or DDPSpawn, and overridden function where LightningDistributed.rank and device setted, could cause silent failures.

Now the src is not respected in torch broadcast, fix the issue

Fixes #9692

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@four4fish four4fish marked this pull request as draft September 24, 2021 19:03
@four4fish four4fish marked this pull request as ready for review September 24, 2021 19:17
@four4fish four4fish marked this pull request as draft September 24, 2021 19:59
@ananthsub ananthsub added bug Something isn't working deprecation Includes a deprecation labels Sep 24, 2021
@ananthsub ananthsub added this to the v1.5 milestone Sep 24, 2021
@four4fish four4fish marked this pull request as ready for review September 24, 2021 20:13
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have a look at the tests/deprecated_api where we should add a quick test for the 1.7 removal :)

@codecov
Copy link

codecov bot commented Sep 24, 2021

Codecov Report

Merging #9691 (a7f74d1) into master (8fcdcb5) will decrease coverage by 4%.
The diff coverage is 67%.

❗ Current head a7f74d1 differs from pull request most recent head db5e4e3. Consider uploading reports for the commit db5e4e3 to get more accurate results

@@           Coverage Diff           @@
##           master   #9691    +/-   ##
=======================================
- Coverage      93%     89%    -4%     
=======================================
  Files         179     178     -1     
  Lines       15306   15297     -9     
=======================================
- Hits        14201   13576   -625     
- Misses       1105    1721   +616     

Copy link
Contributor

@ananthsub ananthsub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think there's an optimization opportunity for broadcast but we can pick it up in a follow up PR along with tensor specializations

@mergify mergify bot added the ready PRs ready to be merged label Sep 24, 2021
@ananthsub ananthsub added the distributed Generic distributed-related topic label Sep 24, 2021
@mergify mergify bot removed the has conflicts label Sep 24, 2021
@ananthsub ananthsub merged commit ddf6967 into Lightning-AI:master Sep 25, 2021
@Borda Borda changed the title Deprecate LightningDistributed and keep logic in ddp/ddpSpawn directly Deprecate LightningDistributed and keep logic in ddp/ddpSpawn directly Mar 10, 2023
@Borda Borda mentioned this pull request Mar 10, 2023
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working deprecation Includes a deprecation distributed Generic distributed-related topic ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate LightningDistributed and keep broadcast in ddp/ddpSpawn directly
4 participants