Skip to content

Validate the precision input earlier #9763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 15, 2021

Conversation

carmocca
Copy link
Contributor

What does this PR do?

See title. This ensures that self.precision is one of the allowed values even when set_precision_plugin hasn't been called yet.

Part of #9287

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • [n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@carmocca carmocca requested a review from rohitgr7 September 29, 2021 16:17
@awaelchli awaelchli enabled auto-merge (squash) September 29, 2021 19:46
@mergify mergify bot added the ready PRs ready to be merged label Sep 29, 2021
@mergify mergify bot removed the has conflicts label Sep 30, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT !

@codecov
Copy link

codecov bot commented Oct 12, 2021

Codecov Report

Merging #9763 (fdc7a05) into master (6429de8) will increase coverage by 4%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #9763    +/-   ##
=======================================
+ Coverage      89%     93%    +4%     
=======================================
  Files         179     179            
  Lines       15831   15833     +2     
=======================================
+ Hits        14053   14676   +623     
+ Misses       1778    1157   -621     

@awaelchli awaelchli merged commit db4e770 into master Oct 15, 2021
@awaelchli awaelchli deleted the refactor/validate-precision-earlier branch October 15, 2021 17:30
rohitgr7 pushed a commit to Tshimanga/pytorch-lightning that referenced this pull request Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants