-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Validate the precision input earlier #9763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carmocca
commented
Sep 29, 2021
rohitgr7
approved these changes
Sep 29, 2021
awaelchli
approved these changes
Sep 29, 2021
ananthsub
approved these changes
Sep 29, 2021
SkafteNicki
approved these changes
Sep 30, 2021
tchaton
approved these changes
Oct 1, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT !
Borda
approved these changes
Oct 12, 2021
Codecov Report
@@ Coverage Diff @@
## master #9763 +/- ##
=======================================
+ Coverage 89% 93% +4%
=======================================
Files 179 179
Lines 15831 15833 +2
=======================================
+ Hits 14053 14676 +623
+ Misses 1778 1157 -621 |
s-rog
approved these changes
Oct 13, 2021
rohitgr7
pushed a commit
to Tshimanga/pytorch-lightning
that referenced
this pull request
Oct 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
See title. This ensures that
self.precision
is one of the allowed values even whenset_precision_plugin
hasn't been called yet.Part of #9287
Does your PR introduce any breaking changes? If yes, please list them.
None
Before submitting
PR review