Skip to content

Fail the test when a DeprecationWarning is raised #9940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 51 commits into from
Nov 17, 2021

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Oct 15, 2021

What does this PR do?

Fixes #9939

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • [n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @Borda @tchaton @carmocca @akihironitta

@carmocca carmocca added the ci Continuous Integration label Oct 15, 2021
@carmocca carmocca added this to the v1.5 milestone Oct 15, 2021
@carmocca carmocca self-assigned this Oct 15, 2021
@carmocca carmocca force-pushed the ci/fail-on-deprecation branch from 58046c8 to 31cf068 Compare October 18, 2021 01:09
@tchaton tchaton removed this from the v1.5 milestone Nov 1, 2021
@carmocca carmocca enabled auto-merge (squash) November 16, 2021 16:37
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@mergify mergify bot added the ready PRs ready to be merged label Nov 16, 2021
@carmocca carmocca force-pushed the ci/fail-on-deprecation branch from fb7158a to 459187f Compare November 17, 2021 16:05
@codecov
Copy link

codecov bot commented Nov 17, 2021

Codecov Report

Merging #9940 (0c4fbf7) into master (ff3443f) will decrease coverage by 0%.
The diff coverage is n/a.

❗ Current head 0c4fbf7 differs from pull request most recent head 4d4dbdb. Consider uploading reports for the commit 4d4dbdb to get more accurate results

@@          Coverage Diff           @@
##           master   #9940   +/-   ##
======================================
- Coverage      92%     92%   -0%     
======================================
  Files         178     178           
  Lines       16246   16246           
======================================
- Hits        14905   14904    -1     
- Misses       1341    1342    +1     

@carmocca carmocca disabled auto-merge November 17, 2021 22:34
@carmocca carmocca merged commit 0fa07da into master Nov 17, 2021
@carmocca carmocca deleted the ci/fail-on-deprecation branch November 17, 2021 22:41
Raalsky pushed a commit to neptune-ai/pytorch-lightning that referenced this pull request Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration priority: 0 High priority task ready PRs ready to be merged tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fail the test when a DeprecationWarning is raised
6 participants