-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Fail the test when a DeprecationWarning
is raised
#9940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carmocca
commented
Oct 15, 2021
carmocca
commented
Oct 15, 2021
pytorch_lightning/trainer/connectors/logger_connector/logger_connector.py
Outdated
Show resolved
Hide resolved
58046c8
to
31cf068
Compare
12 tasks
11 tasks
ananthsub
approved these changes
Nov 16, 2021
awaelchli
reviewed
Nov 16, 2021
tchaton
approved these changes
Nov 16, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
10 tasks
awaelchli
approved these changes
Nov 17, 2021
fb7158a
to
459187f
Compare
Codecov Report
@@ Coverage Diff @@
## master #9940 +/- ##
======================================
- Coverage 92% 92% -0%
======================================
Files 178 178
Lines 16246 16246
======================================
- Hits 14905 14904 -1
- Misses 1341 1342 +1 |
12 tasks
Raalsky
pushed a commit
to neptune-ai/pytorch-lightning
that referenced
this pull request
Nov 23, 2021
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #9939
Does your PR introduce any breaking changes? If yes, please list them.
None
Before submitting
PR review
cc @Borda @tchaton @carmocca @akihironitta