Skip to content

Add KFold Loop example #9965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 25 commits into from
Oct 18, 2021
Merged

Add KFold Loop example #9965

merged 25 commits into from
Oct 18, 2021

Conversation

tchaton
Copy link
Contributor

@tchaton tchaton commented Oct 16, 2021 •
edited
Loading

What does this PR do?

This PR adds a KFold example implemented on top of PyTorch Lightning Loop Customization.

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@tchaton tchaton self-assigned this Oct 16, 2021
@tchaton tchaton added this to the v1.5 milestone Oct 16, 2021
@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@codecov
Copy link

codecov bot commented Oct 16, 2021 •
edited
Loading

Codecov Report

Merging #9965 (8f84ea0) into master (a99b744) will increase coverage by 0%.
The diff coverage is 100%.

❗ Current head 8f84ea0 differs from pull request most recent head 3f51783. Consider uploading reports for the commit 3f51783 to get more accurate results

@@          Coverage Diff           @@
##           master   #9965   +/-   ##
======================================
  Coverage      93%     93%           
======================================
  Files         179     179           
  Lines       15805   15831   +26     
======================================
+ Hits        14641   14670   +29     
+ Misses       1164    1161    -3

justusschock
justusschock approved these changes Oct 16, 2021
View reviewed changes
Copy link
Member

@justusschock justusschock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, simple and comprehensive

rohitgr7
rohitgr7 reviewed Oct 16, 2021
View reviewed changes
awaelchli
awaelchli approved these changes Oct 18, 2021
View reviewed changes
@mergify mergify bot added the ready PRs ready to be merged label Oct 18, 2021
@tchaton tchaton requested a review from rohitgr7 October 18, 2021 10:01
@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

3 similar comments
@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

rohitgr7
rohitgr7 approved these changes Oct 18, 2021
View reviewed changes
SeanNaren
SeanNaren reviewed Oct 18, 2021
View reviewed changes
@mergify mergify bot removed the has conflicts label Oct 18, 2021
@tchaton tchaton enabled auto-merge (squash) October 18, 2021 11:00
@tchaton tchaton disabled auto-merge October 18, 2021 11:47
carmocca
carmocca reviewed Oct 18, 2021
View reviewed changes
@mergify mergify bot removed the has conflicts label Oct 18, 2021
@tchaton tchaton merged commit 86df7dc into master Oct 18, 2021
@tchaton tchaton deleted the add_example_kfold_loop branch October 18, 2021 15:27
rohitgr7 pushed a commit to Tshimanga/pytorch-lightning that referenced this pull request Oct 18, 2021
@tchaton @rohitgr7
Add KFold Loop example (Lightning-AI#9965)
431919f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeanNaren SeanNaren SeanNaren left review comments

@carmocca carmocca carmocca left review comments

@justusschock justusschock justusschock approved these changes

@awaelchli awaelchli awaelchli approved these changes

@rohitgr7 rohitgr7 rohitgr7 approved these changes

@Borda Borda Awaiting requested review from Borda Borda is a code owner

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@edenlightning edenlightning Awaiting requested review from edenlightning

Assignees

@tchaton tchaton

Labels
example ready PRs ready to be merged
Projects
None yet
Milestone
pl:1.5
Development

Successfully merging this pull request may close these issues.
6 participants
@tchaton @awaelchli @SeanNaren @carmocca @justusschock @rohitgr7