Skip to content

Simplify track grad norm condition #9992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 19, 2021
Merged

Conversation

carmocca
Copy link
Contributor

What does this PR do?

Part of #9287

Does your PR introduce any breaking changes? If yes, please list them.

None, track_grad_norm == -1 is the default value (inactive). Passing 0 will result in an error after #9765.

can_log is already checked inside the LoggerConnector

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • [n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@carmocca carmocca added this to the v1.5 milestone Oct 18, 2021
@carmocca carmocca self-assigned this Oct 18, 2021
@codecov
Copy link

codecov bot commented Oct 18, 2021

Codecov Report

Merging #9992 (26938f8) into master (a99b744) will decrease coverage by 4%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #9992    +/-   ##
=======================================
- Coverage      93%     89%    -4%     
=======================================
  Files         179     179            
  Lines       15805   15803     -2     
=======================================
- Hits        14630   14022   -608     
- Misses       1175    1781   +606     

@carmocca carmocca enabled auto-merge (squash) October 18, 2021 14:14
@mergify mergify bot added the ready PRs ready to be merged label Oct 19, 2021
@mergify mergify bot requested a review from a team October 19, 2021 08:31
@carmocca carmocca merged commit bb2dc68 into master Oct 19, 2021
@carmocca carmocca deleted the refactor/track-grad-norm-condition branch October 19, 2021 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants