1.17.2, no ending processing incremental #437

Fred-Vatin · 2021-03-02T15:29:08Z

VS Code version	OS	Extension version
1.53.2	Win 10 x64 pro (french) 18363.1379	1.17.2

Steps to reproduce

Open a lua file that used to work with v1.17.0
Put the cursor on any function or variable
Go to definition or references fails
Status bar shows this processing that never ends

Results

Go to definition or references fails

Environment (please complete the following information):

Is WSL remote: NO

##Workaround
Revert to v1.17 solves the issue.

sumneko · 2021-03-03T02:00:11Z

Please show me your log, see https://github.com/sumneko/lua-language-server/wiki/Default-log-path

Ketho · 2021-03-03T06:08:28Z

For me the status bar stays stuck at "Processing hover", at least with emmylua files loaded.
But I sometimes also get stuck on "Processing incremental semantic token" before I hover over anything.

lua.language.server.1.17.2.mp4

sumneko · 2021-03-03T06:33:13Z

76f1b37
Please try to apply this commit manually and see if the issue is resolved

Ketho · 2021-03-03T06:40:31Z

I edited the file C:\Users\Ketho\.vscode\extensions\sumneko.lua-1.17.2\server\script\files.lua and manually removed those lines but it didn't fix the issue after restarting :(

sumneko · 2021-03-03T06:52:32Z

cc6ec7e
Please try this

Ketho · 2021-03-03T07:00:21Z

Nope, still stuck on hover

sumneko · 2021-03-03T07:02:03Z

Please show me the new log

Ketho · 2021-03-03T07:04:55Z

file_d%3A_test.log
service.log

sumneko · 2021-03-03T07:08:30Z

From the log, it seems that you haven't done any operation. Please make sure that you sent the correct log.
The main problem is that I cannot reproduce this issue. Can you provide a demo project?

Ketho · 2021-03-03T07:19:32Z

I was sure I tried to hover over one of my variables. The hover does work for functions though.
Could you try this demo project? I tried to make it as small as possible.
test.zip

sumneko · 2021-03-03T07:25:55Z

I can reproduce it with your demo project, many thanks!

Fred-Vatin · 2021-03-03T08:13:08Z

Please show me your log, see https://github.com/sumneko/lua-language-server/wiki/Default-log-path

Here is the log from v1.17.2 when opening any lua file like this one.

sumneko · 2021-03-03T09:47:04Z

Please try this commit

Fred-Vatin · 2021-03-03T10:04:09Z

Please try this commit

This seems good ! 👍

Fred-Vatin · 2021-03-03T12:10:32Z

But still the same issue on 1.17.3

sumneko · 2021-03-03T12:14:08Z

I have tested #437 (comment) in 1.17.3 and it works well.
Is that works well for you?
Could you provide a demo project?

Fred-Vatin · 2021-03-03T12:18:53Z

I have tested #437 (comment) in 1.17.3 and it works well.
Is that works well for you?
Could you provide a demo project?

Still the same lua script I provided before but now it is stuck at

I tried to change the #437 (commit) to no avail.

Here is the log with #437 (commit) applied.

Here is my settings for the extensions.

	// # EXTENSION Lua
	"Lua.completion.callSnippet": "Both",
	"Lua.diagnostics.globals": ["gg"],
	"Lua.runtime.version": "Lua 5.2",
	"Lua.diagnostics.severity": {
		"unused-function": "Hint",
		"unused-local": "Warning"
	},
	"Lua.diagnostics.workspaceDelay": 1000,
	"Lua.hint.enable": true,
	"Lua.hint.setType": true,

1.17.0 is blazingly fast and bug free for me with these settings.

sumneko · 2021-03-03T12:29:43Z

Did you mean you have tried this project https://github.com/sumneko/lua-language-server/files/6074215/test.zip in 1.17.3, and it stucked when hover model at test.lua?

Fred-Vatin · 2021-03-03T12:33:13Z

Did you mean you have tried this project https://github.com/sumneko/lua-language-server/files/6074215/test.zip in 1.17.3, and it stucked when hover model at test.lua?

I’m sorry, I provided the wrong link. Here it is.

It happens as soon as I load any lua file in VSC, even doing nothing. I updated and corrected my previous comment to add more details if it helps.

sumneko · 2021-03-03T13:14:43Z

Im a little confused.
So at your side, the issue is gone in 1.17.2 with applying commit b06ba33, but come back in 1.17.3, am I right?

Fred-Vatin · 2021-03-03T14:30:54Z

Im a little confused.
So at your side, the issue is gone in 1.17.2 with applying commit b06ba33, but come back in 1.17.3, am I right?

It seemed yes. I replaced the guide.lua in the 1.17.2 with the one provided in #437 (commit). Then all seemed fine.

Then I updated to 1.17.3, took car to delete previous version in %homepath%.vscode\extensions and still buggy.

Did the log from 1.17.3 help ?

Fred-Vatin · 2021-03-03T14:33:55Z

The guide.lua I downloaded then was this one. Is this the one you wanted me to test, right ?

sumneko · 2021-03-03T14:51:36Z

Yes.

sumneko · 2021-03-03T15:06:42Z

Eventually I found that there are 2 bugs, one of which I have fixed in 1.17.3, and the other bug only occurs when opening a single file.
This is why I have been unable to reproduce this problem before, because another person provided a folder containing multiple files, and I always opened the entire folder directly, so everything was normal. I haven't found that you only opened a single file. This is indeed reflected in the log, but I didn't notice it.
Now I can reproduce your problem, but it is late at night here, and I will fix it tomorrow.

Fred-Vatin · 2021-03-03T15:09:16Z

Eventually I found that there are 2 bugs, one of which I have fixed in 1.17.3, and the other bug only occurs when opening a single file.
This is why I have been unable to reproduce this problem before, because another person provided a folder containing multiple files, and I always opened the entire folder directly, so everything was normal. I haven't found that you only opened a single file. This is indeed reflected in the log, but I didn't notice it.
Now I can reproduce your problem, but it is late at night here, and I will fix it tomorrow.

I’m glad you could reproduce the bug. Good night.

Fred-Vatin · 2021-03-03T15:12:38Z

Im a little confused.
So at your side, the issue is gone in 1.17.2 with applying commit b06ba33, but come back in 1.17.3, am I right?

It seemed yes. I replaced the guide.lua in the 1.17.2 with the one provided in #437 (commit). Then all seemed fine.

Then I updated to 1.17.3, took car to delete previous version in %homepath%.vscode\extensions and still buggy.

Did the log from 1.17.3 help ?

Fred-Vatin · 2021-03-03T15:15:13Z

The guide.lua I downloaded then was this one. Is this the one you wanted me to test, right ?

(Oups, sorry for having closed the issue. Wrong button while I was writing a comment)

I did the test again with 1.17.2 replacing the guide.lua by the one above and failed to reproduce the success. I have the same issue with 1.17.2 with modified guide.lua. After restarted VSC, of course.

sumneko · 2021-03-03T15:17:53Z

The guide.lua I downloaded then was this one. Is this the one you wanted me to test, right ?

(Oups, sorry for having closed the issue. Wrong button while I was writing a comment)

I did the test again with 1.17.2 replacing the guide.lua by the one above and failed to reproduce the success. I have the same issue with 1.17.2 with modified guide.lua. After restarted VSC, of course.

Open single file or open folder?

Fred-Vatin · 2021-03-03T15:18:30Z

The guide.lua I downloaded then was this one. Is this the one you wanted me to test, right ?

(Oups, sorry for having closed the issue. Wrong button while I was writing a comment)
I did the test again with 1.17.2 replacing the guide.lua by the one above and failed to reproduce the success. I have the same issue with 1.17.2 with modified guide.lua. After restarted VSC, of course.

Open single file or open folder?

Single file

Ketho · 2021-03-03T15:19:39Z

Eventually I found that there are 2 bugs, one of which I have fixed in 1.17.3, and the other bug only occurs when opening a single file.

Yea there seem to be 2 separate bugs, I also encountered the issue with only opening a single file but I just assumed they were related... Sorry for that, 晚安~

sumneko · 2021-03-03T15:22:12Z

Eventually I found that there are 2 bugs, one of which I have fixed in 1.17.3, and the other bug only occurs when opening a single file.

Yea there seem to be 2 separate bugs, I also encountered the issue with only opening a single file but I just assumed they were related... Sorry for that, 晚安。

It’s okay, the performance of these two bugs is very similar, it is really difficult to distinguish

sumneko · 2021-03-04T07:42:32Z

Please manually update script/plugin.lua and check if it works!

Ketho · 2021-03-04T07:56:00Z

Works for me! It no longer gets stuck on "Processing incremental semantic tokens" when opening a single Lua file.

Fred-Vatin · 2021-03-04T16:12:31Z

Please manually update script/plugin.lua and check if it works!

I didn’t have to. 1.17.4 solved this issue for me.

sumneko · 2021-03-05T03:18:38Z

Seems fixed, closing

sumneko added the bug Something isn't working label Mar 3, 2021

sumneko added a commit that referenced this issue Mar 3, 2021

#435 #437 why not cache generic results?

b06ba33

sniper00 mentioned this issue Mar 3, 2021

无法提示ipair中的的类型 #435

Closed

Fred-Vatin closed this as completed Mar 3, 2021

Fred-Vatin reopened this Mar 3, 2021

sumneko added a commit that referenced this issue Mar 4, 2021

#437 plugin blocks first opened file

e65bebc

sumneko closed this as completed Mar 5, 2021

1.17.2, no ending processing incremental #437

1.17.2, no ending processing incremental #437

Comments

Fred-Vatin commented Mar 2, 2021

Steps to reproduce

Results

sumneko commented Mar 3, 2021

Ketho commented Mar 3, 2021

sumneko commented Mar 3, 2021

Ketho commented Mar 3, 2021 • edited Loading

sumneko commented Mar 3, 2021 • edited Loading

Ketho commented Mar 3, 2021

sumneko commented Mar 3, 2021

Ketho commented Mar 3, 2021

sumneko commented Mar 3, 2021

Ketho commented Mar 3, 2021

sumneko commented Mar 3, 2021

Fred-Vatin commented Mar 3, 2021

sumneko commented Mar 3, 2021

Fred-Vatin commented Mar 3, 2021

Fred-Vatin commented Mar 3, 2021

sumneko commented Mar 3, 2021

Fred-Vatin commented Mar 3, 2021 • edited Loading

sumneko commented Mar 3, 2021

Fred-Vatin commented Mar 3, 2021 • edited Loading

sumneko commented Mar 3, 2021

Fred-Vatin commented Mar 3, 2021 • edited Loading

Fred-Vatin commented Mar 3, 2021

sumneko commented Mar 3, 2021

sumneko commented Mar 3, 2021

Fred-Vatin commented Mar 3, 2021

Fred-Vatin commented Mar 3, 2021

Fred-Vatin commented Mar 3, 2021 • edited Loading

sumneko commented Mar 3, 2021

Fred-Vatin commented Mar 3, 2021

Ketho commented Mar 3, 2021 • edited Loading

sumneko commented Mar 3, 2021

sumneko commented Mar 4, 2021

Ketho commented Mar 4, 2021

Fred-Vatin commented Mar 4, 2021

sumneko commented Mar 5, 2021

Ketho commented Mar 3, 2021 •

edited

Loading

sumneko commented Mar 3, 2021 •

edited

Loading

Fred-Vatin commented Mar 3, 2021 •

edited

Loading

Fred-Vatin commented Mar 3, 2021 •

edited

Loading

Fred-Vatin commented Mar 3, 2021 •

edited

Loading

Fred-Vatin commented Mar 3, 2021 •

edited

Loading

Ketho commented Mar 3, 2021 •

edited

Loading