-
-
Notifications
You must be signed in to change notification settings - Fork 350
添加对 EmmyLua table type 的支持 #340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sumneko
reviewed
Jan 4, 2021
嗯嗯好,我处理下 |
uhziel
commented
Jan 5, 2021
@@ -16,6 +16,11 @@ local function getTypesOfFile(uri) | |||
or src.type == 'doc.class.name' | |||
or src.type == 'doc.extends.name' | |||
or src.type == 'doc.alias.name' then | |||
if src.type == 'doc.type.name' then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里我限制了下,通过类型名,比如 ‘table’,不会它找到---@type table<k, v> 里的 table。进而导致我这里新加的用例失败。
先合了,有问题以后再说 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
相关讨论见 #331
还有个用例需要扩充 simple 信息才能放开