Skip to content

Build openblas with ucrt mingw #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Conversation

mattip
Copy link
Collaborator

@mattip mattip commented May 18, 2022

Replaces #75 since I don't have push permissions to that repo.

Fixes #68 fixes #74

I don't understand some of the differences between build_openblas.ps1 and build_openblas.sh. Some of the variable names have changed, there is some renaming that is different, and it seems the zip step at the end is missing.

@matthew-brett
Copy link
Contributor

Yes - sorry - the .ps1 file was just me working it out as I went. It really needs a rewrite, and it will probably work as a refactor of the .sh script. Yes, it does need the -ucrt toolchain - Scipy is using rtools-4 from choco - I believe.

@carlkl
Copy link

carlkl commented May 28, 2022

AFAIK OpenBLAS still uses long double for intermediate calculations. i.e.: interface/zrotg.c
So using the $long_double="mlong-double-64" flag on Windows is not recommended without patching OpenBLAS.
See i.e. OpenMathLib/OpenBLAS#1711 and OpenMathLib/OpenBLAS#1270. See also this comment: OpenMathLib/OpenBLAS#1270 (comment)
The non-standard toolchain called mingwpy was at this time a mingw-w64 toolchain patched to use "mlong-double-64" as default.

@mattip
Copy link
Collaborator Author

mattip commented Aug 29, 2022

Closing in favor of #82

@mattip mattip closed this Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pkgconfig files are missing in the built package Consider modern mingw-w64 UCRT build
3 participants