Round delay in call_later()

[fantix]

• Write unit test.
• Make the test pass.

• Fixes Incorrect time calculation in loop.call_at() #233.

[jlaine]

If we want to respect the guarantee that the CB is called "no earlier than X", isn't ceil() more appropriate than round()?

[fantix]

@jlaine replied in #233 (comment)

[jlaine]

Ok sorry for the duplicate message

[1st1]

So is the new test stable?

[fantix]

Yeah I think so

[1st1]

Alright, merged. Thank you! :)

[1st1]

@fantix got this CI failure this morning:

Could you please take another look at the test? Is it possible to make it any more reliable? If not, I suggest we relax it a bit or drop it.

[1st1]

(or maybe we should go with @jlaine suggestion to use ceil())

[fantix]

@1st1 ceil() may not fix this one - there's arbitrary time spent before the clock starts ticking. I think an absolute safe number would be 69, but it's probably not much meaningful anymore. For what is worth, maybe 69 for now?

[1st1]

Let's try it... Would the old code (without round()) fail on that?

[fantix]

@1st1 the old code may probably succeed with this test at 69 I think

[1st1]

Alright, I pushed e3b00b8

[fantix]

Oh, thanks for that! 🙇