Skip to content

Fix future issue in sock_connect() #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Fix future issue in sock_connect() #389

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0360dab
Fix future issue in sock_connect()
fantix Feb 8, 2021
cd85662
Fix comments
fantix Feb 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions uvloop/loop.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -975,7 +975,7 @@ cdef class Loop:

if UVLOOP_DEBUG:
if fut.cancelled():
# Shouldn't happen with _SyncSocketReaderFuture.
# Shouldn't happen with _SyncSocketWriterFuture.
raise RuntimeError(
f'_sock_sendall is called on a cancelled Future')

Expand Down Expand Up @@ -1059,7 +1059,8 @@ cdef class Loop:
return fut

cdef _sock_connect_cb(self, fut, sock, address):
if fut.cancelled():
if fut.done():
# Refs #378: this may be called multiple times.
return

try:
Expand Down