Skip to content

Replaced obsolete method for record fetching with RBAC in application controller #4598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 6, 2018
Merged

Replaced obsolete method for record fetching with RBAC in application controller #4598

merged 2 commits into from
Sep 6, 2018

Conversation

romanblanco
Copy link
Member

@romanblanco romanblanco commented Sep 4, 2018 •
edited
Loading

Merge together with ManageIQ/manageiq#17943

Links

Steps for Testing/QA

  • Clone a VM

@romanblanco romanblanco mentioned this pull request Sep 4, 2018
Merged
@romanblanco romanblanco force-pushed the app_ctrl_checked_ids_cleanup branch from b8890a2 to 02d5e05 Compare September 5, 2018 08:29
@romanblanco romanblanco mentioned this pull request Sep 5, 2018
Merged
@romanblanco romanblanco force-pushed the app_ctrl_checked_ids_cleanup branch from 02d5e05 to f8fb9f1 Compare September 6, 2018 09:27
@miq-bot
Copy link
Member

miq-bot commented Sep 6, 2018

Checked commits romanblanco/manageiq-ui-classic@f8fb9f1~...8f8f155 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 👍

PanSpagetka
PanSpagetka approved these changes Sep 6, 2018
View reviewed changes
Copy link
Contributor

@PanSpagetka PanSpagetka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am pretty sure, that code inside if request.parameters[:pressed].starts_with?("host_") can be safely deleted. Otherwise it seems to works same as in master.

@mzazrivec mzazrivec self-assigned this Sep 6, 2018
@mzazrivec mzazrivec added this to the Sprint 94 Ending Sep 10, 2018 milestone Sep 6, 2018
@mzazrivec mzazrivec merged commit be2248c into ManageIQ:master Sep 6, 2018
@mzazrivec mzazrivec added the rbac label Sep 6, 2018
@romanblanco romanblanco deleted the app_ctrl_checked_ids_cleanup branch September 6, 2018 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PanSpagetka PanSpagetka PanSpagetka approved these changes

Assignees

@mzazrivec mzazrivec

Labels
rbac refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@romanblanco @miq-bot @PanSpagetka @mzazrivec