Skip to content

Replaced obsolete RBAC test while removing automate instances #4644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 18, 2018

Conversation

romanblanco
Copy link
Member

Replacing obsolete RBAC test

Links

Steps for Testing/QA

  • go to Automate - Explorer
  • select an instance
  • Remove the selected instance

@miq-bot miq-bot added the wip label Sep 11, 2018
@romanblanco romanblanco force-pushed the ae_class_id_with_rbac branch 2 times, most recently from 5e3cf09 to a168841 Compare September 12, 2018 12:04
@romanblanco romanblanco changed the title [WIP] Replaced obsolete RBAC test while removing automate instances Replaced obsolete RBAC test while removing automate instances Sep 12, 2018
@miq-bot miq-bot removed the wip label Sep 12, 2018
@mzazrivec
Copy link
Contributor

@romanblanco Could you -- if possible -- address the above rubocop warnings? Thanks.

@miq-bot
Copy link
Member

miq-bot commented Sep 13, 2018

Checked commits romanblanco/manageiq-ui-classic@fca7ee5~...d6eaea1 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🏆

Copy link
Contributor

@PanSpagetka PanSpagetka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even thought i don't really like conditions like this: if (@sb[:row_selected] = find_checked_items).present? I can live with it. Works in UI.

@mzazrivec mzazrivec self-assigned this Sep 18, 2018
@mzazrivec mzazrivec added this to the Sprint 95 Ending Sep 24, 2018 milestone Sep 18, 2018
@mzazrivec mzazrivec merged commit 3f71bf6 into ManageIQ:master Sep 18, 2018
@romanblanco romanblanco deleted the ae_class_id_with_rbac branch September 18, 2018 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants