Convert role form from ruby into React #9281
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liu-samuel
force-pushed
the
substring-check
branch
from
6688ca5 to
8a8e60b
Compare
|
@liu-samuel Can you please resolve the conflicts here |
liu-samuel
force-pushed
the
substring-check
branch
4 times, most recently
from
0c02479 to
b2895ab
Compare
liu-samuel
force-pushed
the
substring-check
branch
from
15dda4a to
d71008a
Compare
GilbertCherrie
force-pushed
the
substring-check
branch
from
d71008a to
9928380
Compare
GilbertCherrie
approved these changes
Apr 28, 2025
GilbertCherrie
force-pushed
the
substring-check
branch
from
c63264b to
3c22295
Compare
|
Checked commits liu-samuel/manageiq-ui-classic@9928380~...3c22295 with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.62.0, and yamllint app/views/ops/_rbac_role_details.html.haml
|
|
This pull request is not mergeable. Please rebase and repush. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converts user role form from haml to React and add cypress testing
Before:
After:
