Add improvements to exception handling messages #454
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minor improvements to the exception service: * split exception.catcher into a function per use case * add documentation for recommended usage * rename to exception.service.js to follow naming conventions Add a guard clause to the `$exceptionHandler` decorator to ensure an error object. Add a missing `.catch` clause to the login function.
|
Checked commit jjlangholtz@740f362 with ruby 2.2.6, rubocop 0.46.0, and haml-lint 0.19.0 |
chriskacerguis
approved these changes
Jan 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor improvements to the exception service:
exception.service.jsto follow naming conventionsAdd a guard clause to the
$exceptionHandlerdecorator to ensure anerror object.
Add a missing
.catchclause to the login function.Note that you will still error messages when closing modals, but the output is less noisy. This is due to
angular-ui-bootstrapnot catching up to angular 1.6.1 yet. Looks like it is actively being fixed from angular-ui/bootstrap#6360@miq-bot add_label euwe/no, bug