Skip to content
This repository was archived by the owner on Aug 25, 2021. It is now read-only.

Fix enable/disable buttons for rbac users form. #88

Merged
merged 1 commit into from
Nov 12, 2018

Conversation

Hyperkid123
Copy link
Contributor

When editing some form and changing some values that are array or object and then changing then to match initial values, the pristine flag will be false even though it should be true.

React-final-form API is no making deep compassion, but there is an open PR that should fix it. See: final-form/react-final-form#151

Until its fixed, i've added very simple compassion.

@Hyperkid123 Hyperkid123 force-pushed the fix-user-form-pristine branch from f1a77a3 to 34612a1 Compare October 15, 2018 13:31
@Hyperkid123
Copy link
Contributor Author

@miq-bot add-label bug

@Hyperkid123
Copy link
Contributor Author

@miq-bot assign @karelhala

@Hyperkid123 Hyperkid123 force-pushed the fix-user-form-pristine branch from 34612a1 to 52ad87b Compare November 7, 2018 08:43
@miq-bot
Copy link
Member

miq-bot commented Nov 7, 2018

Checked commit Hyperkid123@52ad87b with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🍪

@martinpovolny martinpovolny merged commit 03cfb67 into ManageIQ:master Nov 12, 2018
@karelhala
Copy link
Contributor

🎉 This PR is included in version 0.11.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Hyperkid123 Hyperkid123 deleted the fix-user-form-pristine branch November 12, 2018 09:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants