Convert frozendict/src/*/cpython_src/
to use submodules instead of manually-copied files
#19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is obviously a "cleaner" way of doing things (it means less files stored directly in the repo), and it means that if the upstream Python-headers change, you only need to update the relevant commit-hash in
.gitmodules
and thengit submodule update
.The downside is that this then leads to 5 separate copies of the complete upstream https://github.com/python/cpython repo being stored in your local workspace, gobbling up over 2GB of diskspace 😢 Unfortunately the
--depth
option ofgit sumbodule add
doesn't work in combination with the-b
option https://git-scm.com/docs/git-submodule(I also tried having just one submodule pointing to the
main
branch of upstream cpython, and then having each of the 3_6, 3_7, 3_8, 3_9 and 3_10 submodules pointing to this "shared" submodule, butgit
doesn't allow you to do that).So it's entirely up to you @Marco-Sulla whether you want to accept this or not.
(Just in case you've not used git submodules before - after cloning this PR you need to run
git submodule update --init
... and then wait a while... 😉 )