This repository was archived by the owner on Jul 12, 2020. It is now read-only.
Refactor trigger to style text only if no add-class #112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicholaschuayunzhi
approved these changes
Jul 10, 2019
Chng-Zhi-Xuan
approved these changes
Jul 14, 2019
yamgent
reviewed
Jul 15, 2019
| @@ -1,5 +1,5 @@ | |||
| <template> | |||
| <span ref="trigger" :class="[addClass]"><slot></slot></span> | |||
| <span ref="trigger" :class="[addClass || (this.trigger === 'click' ? 'click-trigger' : 'other-trigger')]"><slot></slot></span> | |||
There was a problem hiding this comment.
addClass by convention allows the author to append additional classes to the component, but it seems that addClass here is actually "overriding" click-trigger or other-trigger, is that intended?
There was a problem hiding this comment.
Yeah, it is overriding. Should I create another pr to revert this?
There was a problem hiding this comment.
Should I create another pr to revert this?
Yes please do. If that means that you can no longer remove the dash, you can also see if there's alternative ways of getting rid of dotted lines (e.g. maybe introduce a disable-dash attribute or a style attribute to turn it off).
openorclose
added a commit
that referenced
this pull request
Jul 15, 2019
This reverts commit 593169d.
yamgent
pushed a commit
that referenced
this pull request
Jul 15, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put "X" next to an item, remove the rest)
• [x] Enhancement to an existing feature
What is the rationale for this request?
It is hard to add custom styles to trigger elements, as trigger sets the style attribute directly. Let's only add the custom underline style to triggers only when the add-class attribute is not specified, so that users can provide their own classes.
What changes did you make? (Give an overview)
Refactored the underline styles into classes, and then only add the relevant class if add-class attribute is not specified.