Replaced ShadowDepth with Elevation #2786
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A couple more were added in other PRs
Keboo
approved these changes
Jul 19, 2022
Keboo
added
enhancement
release notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2774
Partially fixes #2407
This builds upon the changes made in #2765 and replaces
ShadowDepthwithElevationas discussed in #2774.ShadowDepthis marked as obsolete, but still works, because setting it will also set an equivalentElevation(this can be removed in a future version). I have replaced all uses ofShadowDepthin all styles and demos.Some shadows are slightly different now, both because the
Elevationvalues don't translate exactly to the oldShadowDepthvalues, but also because we now have more granularity and can get closer to the recommended values in the specs. I used https://material.io/design/environment/elevation.html#default-elevations and the individual component specs to find the recommended values for the new system.As a "bonus" I added support for
HorizontalContentAlignmentandVerticalContentAlignmentto theCardstyles, as I needed it to simplify the elevation demo.