Fix PopupBox misalignment on mixed DPI systems #3641
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PopupBox correctly transforms from device coordinates using the PresentationSource transform matrix, but then uses the global system DPI to transform back to device coordinates. This causes placement issues on systems with multiple DPI/scaling settings.
Keboo
added
bug
release notes
Keboo
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PopupBoxcorrectly transforms from device coordinates using thePresentationSourcetransform matrix, but then uses the global system DPI to transform back to device coordinates. This causes placement issues on systems with multiple DPI/scaling settings.These examples were captured on a system with mixed scaling of 100% on the primary screen and 225% on the secondary, with the demo app placed on the latter.
Before:
After:
I chose
BottomAndAlignRightEdgesbecause the misalignment is particularly noticeable, but ultimately every placement mode is misaligned.