platform-checks: Add additional checks around replica_id migration

Author: philip-stoev

misc/python/materialize/checks/replica.py

@@ -11,6 +11,7 @@
 
 from materialize.checks.actions import Testdrive
 from materialize.checks.checks import Check
+from materialize.util import MzVersion
 
 
 class CreateReplica(Check):
@@ -46,7 +47,40 @@ def validate(self) -> Testdrive:
                 123
                 > SELECT * FROM create_replica_view;
                 123
-           """
+
+                # Confirm that all replica_ids have been migrated to the uXXX/sXXX format
+                > SELECT COUNT(*)
+                  FROM mz_cluster_replicas
+                  WHERE id NOT LIKE 's%'
+                  AND id NOT LIKE 'u%';
+                0
+
+                # Confirm that there are CREATE events for all replicas with new-format IDs
+                # resultset should not contain any NULLs.
+                # System and unmanaged replicas have no audit log entries, so we need to exclude
+                # those.
+                > SELECT DISTINCT event_type
+                  FROM mz_cluster_replicas
+                  LEFT JOIN mz_audit_events ON (
+                    mz_cluster_replicas.id = mz_audit_events.details->>'replica_id'
+                    AND mz_audit_events.event_type = 'create'
+                  )
+                  WHERE
+                    mz_cluster_replicas.id LIKE 'u%'
+                    AND mz_cluster_replicas.size IS NOT NULL;
+                create
+                """
+                + """
+                # Confirm that there are DROP events for replicas with old-format IDs
+                > SELECT COUNT(*) >= 2 FROM mz_audit_events
+                  WHERE object_type = 'cluster-replica'
+                  AND event_type = 'drop'
+                  AND details->>'replica_id' NOT LIKE 's%'
+                  AND details->>'replica_id' NOT LIKE 'u%';
+                true
+                """
+                if self.base_version < MzVersion.parse("0.66.0-dev")
+                else ""
             )
         )