[framework] Remove MBEDTLS_USE_PSA_CRYPTO from PK module #167
Conversation
valeriosetti
added
needs-review
github-project-automation
bot
moved this to In Development
in Roadmap pull requests (new board)
USE_PSA guard is not removed because the framework code can be used also with the 3.6 LTS branch, but the guard is ignored when working in tf-psa-crypto repo. Signed-off-by: Valerio Setti <[email protected]>
valeriosetti
force-pushed
the
issue283-framework
branch
from
4aaad73 to
d1739b1
Compare
| /* In TF-PSA-Crypto USE_PSA is always enabled. However we cannot | ||
| * remove this guard because this test code can be used also with | ||
| * mbedtls-3.6 branch. */ | ||
| #if defined(MBEDTLS_USE_PSA_CRYPTO) || defined(PSA_CRYPTO_API_VERSION_MAJOR) |
There was a problem hiding this comment.
I don't think this is incorrect, but I don't understand why it would be needed now. Unless I'm missing something, MBEDTLS_USE_PSA_CRYPTO is still being defined in tf-psa-crypto for now (in config_adjust_legacy_from_psa.h) and still needs to be until we finish getting rid of it on the TLS side.
At some point in the future we'll stop defining it, and then I agree we'll need a change like this one, but in the meantime I don't understand why we'd need this. Am I missing something?
There was a problem hiding this comment.
At some point in the future we'll stop defining it
Arguably TF-PSA-Crypto should keep defining MBEDTLS_USE_PSA_CRYPTO and MBEDTLS_PSA_CRYPTO_CONFIG for at least as long as 3.6 is officially supported, to facilitate the life of third-party code that needs to work both with our LTS branch and our development branch.
There was a problem hiding this comment.
At some point in the future we'll stop defining it, and then I agree we'll need a change like this one, but in the meantime I don't understand why we'd need this. Am I missing something?
No you are not. I was just thinking about this future case and I thought it could be nice to "prepare" framework for it. Since it's not needed I will remove it.
|
Closed as not necessary |
github-project-automation
bot
moved this from In Development
to Done
in Roadmap pull requests (new board)
Description
This helps resolving Mbed-TLS/TF-PSA-Crypto#283
PR checklist