-
Notifications
You must be signed in to change notification settings - Fork 27
Script to search the outcome file for configurations with given requirements #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Script to search the outcome file for configurations with given requirements #20
Conversation
…rements Signed-off-by: Gilles Peskine <[email protected]>
If the outcome file format or the test_suite_config test case descriptions change, this should be detected by the unit tests here. Signed-off-by: Gilles Peskine <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested the script locally and it works correctly. The source looks good to me.
Signed-off-by: Gilles Peskine <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I labelled this pull request "needs-preceding-pr" but there is no indication of what it needs and looking back I can't see what it would need. It's just a new script that doesn't consume anything else except for one long preexisting Python module. It has passed the CI. So I'm going ahead and removing the label "needs-preceding-pr". This makes the PR ready to merge, so I'm merging it. |
Resolves Mbed-TLS/mbedtls#9195
To try it out, grab an outcome file from a nightly.
Testing: I ran
pylint
andmypy
manually. There is no corresponding PR in the main repo because nothing in the main repo depends on it, this is an entry-point script intended for use by maintainers.