fix(0.11): lsp hover doc event order change

## Details

Report: #333

Caused by a recent change to neovim that moved when filetype is set to
after content being set: neovim/neovim#32112

To handle this add a call to `update` after attaching to a buffer for
the first time. This will trigger rendering without needing an event
(previously `BufWinEnter`) to get the initial view to work.

Other small changes:

- Add notes to self about highlight type definition changes in 0.11
- `get_parser` can return `nil` in 0.11 so add `nil` checks around these
- Check whether parsing is needed at both the time of scheduling our
  render update and again when executing it since the state may have
  changed between the 2 and we can potentially avoid the additional
  overhead, similar concept to validating the buffer / window at both of
  these times

Author: MeanderingProgrammer

doc/render-markdown.txt

@@ -1,4 +1,4 @@
-*render-markdown.txt*         For 0.10.0         Last change: 2025 February 25
+*render-markdown.txt*         For 0.10.0         Last change: 2025 February 27
 
 ==============================================================================
 Table of Contents                          *render-markdown-table-of-contents*

lua/render-markdown/colors.lua

@@ -92,8 +92,10 @@ function M.combine(foreground, background, force)
         vim.api.nvim_set_hl(0, name, {
             fg = fg.fg,
             bg = bg.bg,
+            -- TODO(0.11): remove
             ---@diagnostic disable-next-line: undefined-field
             ctermfg = fg.ctermfg,
+            -- TODO(0.11): remove
             ---@diagnostic disable-next-line: undefined-field
             ctermbg = bg.ctermbg,
         })
@@ -111,6 +113,7 @@ function M.bg_to_fg(highlight, force)
         local hl = M.get_hl(highlight)
         vim.api.nvim_set_hl(0, name, {
             fg = hl.bg,
+            -- TODO(0.11): remove
             ---@diagnostic disable-next-line: undefined-field
             ctermfg = hl.ctermbg,
         })
@@ -123,6 +126,7 @@ end
 ---@param name string
 ---@return vim.api.keyset.hl_info
 function M.get_hl(name)
+    -- TODO(0.11): return vim.api.keyset.get_hl_info
     return vim.api.nvim_get_hl(0, { name = name, link = false })
 end
 

lua/render-markdown/core/conceal.lua

@@ -90,6 +90,9 @@ function Conceal:compute(context)
         return
     end
     local parser = vim.treesitter.get_parser(self.buf)
+    if parser == nil then
+        return
+    end
     context:parse(parser)
     parser:for_each_tree(function(tree, language_tree)
         self:compute_tree(context, language_tree:lang(), tree:root())

lua/render-markdown/core/ui.lua

@@ -81,13 +81,11 @@ function M.update(buf, win, event, change)
         return
     end
 
+    local parse = M.parse(buf, win, change)
     local config, buffer_state = state.get(buf), Cache.get(buf)
 
-    -- Need to parse when things change or we have not parsed the visible range yet
-    local parse = change or not Context.contains_range(buf, win)
-
     local update = function()
-        M.run_update(buf, win, parse)
+        M.run_update(buf, win, change)
     end
     if parse and state.log_runtime then
         update = util.wrap_runtime(update)
@@ -103,12 +101,23 @@ end
 ---@private
 ---@param buf integer
 ---@param win integer
----@param parse boolean
-function M.run_update(buf, win, parse)
+---@param change boolean
+---@return boolean
+function M.parse(buf, win, change)
+    -- Need to parse when things change or we have not parsed the visible range yet
+    return change or not Context.contains_range(buf, win)
+end
+
+---@private
+---@param buf integer
+---@param win integer
+---@param change boolean
+function M.run_update(buf, win, change)
     if not util.valid(buf, win) then
         return
     end
 
+    local parse = M.parse(buf, win, change)
     local config, buffer_state = state.get(buf), Cache.get(buf)
     local mode, row = util.mode(), util.row(buf, win)
     local next_state = M.next_state(config, win, mode)
@@ -131,7 +140,8 @@ function M.run_update(buf, win, parse)
             }))
         end
         local hidden = config:hidden(mode, row)
-        for _, extmark in ipairs(buffer_state:get_marks()) do
+        local extmarks = buffer_state:get_marks()
+        for _, extmark in ipairs(extmarks) do
             local mark = extmark:get_mark()
             if mark.conceal and hidden ~= nil and hidden:contains(mark.start_row, mark.start_row) then
                 extmark:hide(M.namespace, buf)
@@ -175,7 +185,7 @@ end
 function M.parse_buffer(props)
     local buf = props.buf
     local has_parser, parser = pcall(vim.treesitter.get_parser, buf)
-    if not has_parser then
+    if not has_parser or parser == nil then
         log.buf('error', 'fail', buf, 'no treesitter parser found')
         return {}
     end

lua/render-markdown/core/util.lua

@@ -148,11 +148,10 @@ function M.file_name(buf)
     end
 end
 
----@param source string|integer
+---@param file string|integer
 ---@return number
-function M.file_size_mb(source)
-    local file = source
-    if type(file) == 'number' then
+function M.file_size_mb(file)
+    if type(file) ~= 'string' then
         file = vim.api.nvim_buf_get_name(file)
     end
     local ok, stats = pcall(function()

lua/render-markdown/health.lua

@@ -5,7 +5,7 @@ local state = require('render-markdown.state')
 local M = {}
 
 ---@private
-M.version = '8.0.12'
+M.version = '8.0.13'
 
 function M.check()
     M.start('version')

lua/render-markdown/integ/source.lua

@@ -28,7 +28,7 @@ end
 ---@return lsp.CompletionItem[]?
 function M.items(buf, row, col)
     local has_parser, parser = pcall(vim.treesitter.get_parser, buf)
-    if not has_parser then
+    if not has_parser or parser == nil then
         return nil
     end
 

lua/render-markdown/manager.lua

@@ -16,7 +16,7 @@ M.group = vim.api.nvim_create_augroup('RenderMarkdown', { clear = true })
 function M.setup()
     -- Lazy Loading: ignores current buffer as FileType event already executed
     if #util.lazy('ft') == 0 and #util.lazy('cmd') == 0 then
-        M.attach_current()
+        M.attach(util.current('buf'))
     end
     -- Attempt to attach to all buffers, cannot use pattern to support plugin directory
     vim.api.nvim_create_autocmd('FileType', {
@@ -52,15 +52,15 @@ end
 function M.set_all(enabled)
     -- Lazy Loading: all previously opened buffers have been ignored
     if #util.lazy('cmd') > 0 then
-        M.attach_current()
+        M.attach(util.current('buf'))
     end
     if enabled ~= nil then
         state.enabled = enabled
     else
         state.enabled = not state.enabled
     end
     for _, buf in ipairs(buffers) do
-        M.trigger_update(buf)
+        M.update(buf, 'UserCommand')
     end
 end
 
@@ -74,21 +74,10 @@ function M.set_current(enabled)
         else
             config.enabled = not config.enabled
         end
-        M.trigger_update(buf)
+        M.update(buf, 'UserCommand')
     end
 end
 
----@private
-function M.attach_current()
-    M.attach(util.current('buf'))
-end
-
----@private
----@param buf integer
-function M.trigger_update(buf)
-    ui.update(buf, vim.fn.bufwinid(buf), 'UserCommand', true)
-end
-
 ---@private
 ---@param buf integer
 function M.attach(buf)
@@ -122,6 +111,15 @@ function M.attach(buf)
             ui.update(buf, win, event, vim.tbl_contains(change_events, event))
         end,
     })
+
+    M.update(buf, 'Initial')
+end
+
+---@private
+---@param buf integer
+---@param event string
+function M.update(buf, event)
+    ui.update(buf, vim.fn.bufwinid(buf), event, true)
 end
 
 ---@private