feature: make behavior when header.border = true consistent whether or not there is a blank newline above/below the header
#183
Labels
enhancement
New feature or request
Comments
|
The top and bottom lines don't get fixed by rendering a virtual line on them. Under the current implementation there's already a virtual line being rendered in both places: #123 (comment) You can see the top one if you hit |
|
I can add an opt in to make the lines always virtual. |
MeanderingProgrammer
added a commit
that referenced
this issue
Sep 24, 2024
## Details Request 1: #182 This change adds support for 2 features. The first is around the padding options for headings. For each of: - `left_margin` - `left_pad` - `right_pad` - `min_width` We now accept an array of numbers in addition to a single number. When the value is an array we index it using the level and we clamp the last value. This is the same behavior we support for `width`. Request 2: #183 This request is simply to allow using virtual lines for heading borders all the time rather than trying to overlay borders on empty lines. This can now be opted in to by setting `border_virtual` to `true`.
|
Added this here: aad1a12. You can opt into it by setting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
Currently, when
header.border = trueand there is a blank newline above the header, the border is applied to the blank newline, but when there is a non-blank line above the header, a "phantom" line is rendered and the border is applied to that "phantom" newline, and this behavior is the same for the border below the header.This makes moving up or down by line when there is a header unpredictable. To make the situation a bit clearer:
The following would look the same:
However, moving the cursor down a line in the first example would move the cursor to the empty line (and hide the border of the header), while moving the cursor down in the second example would move the cursor to the line with the header.
Describe the solution you'd like
When
header.border = true, render the border on a "phantom" line, regardless of whether or not there is an empty line above or below it.This would have the added benefit of fixing the rendering headers at the top and bottom of the file (currently, when there is a header at the top of the file, the top border is not rendered, and the same is true of the bottom border for a header on the last line of the file).
Describe alternatives you've considered
Add a configuration value to control this behavior, eg:
header.border_position, with (perhaps) a value ofoverlaypreserving the current behavior, and a value ofvirtual(or some better-named value) triggering the consistent behavior I've described above.Additional information
Again, I really appreciate this plugin and all of the work you've put into it! It's meaningfully improved my Neovim experience.
The text was updated successfully, but these errors were encountered: